Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AlternativeImage should be in the fileGroup they originated from #505

Closed
kba opened this issue Jun 8, 2020 · 2 comments
Closed

AlternativeImage should be in the fileGroup they originated from #505

kba opened this issue Jun 8, 2020 · 2 comments
Assignees

Comments

@kba
Copy link
Member

kba commented Jun 8, 2020

We agreed that AlternativeImages for a mets:file representing a PAGE-XML should be written into the same fileGroup as the PAGE-XML document.

From: #471

The idea behind the page_same_group parameter is to restrict deleting images to those that are in the same pc:fileGrp as the PAGE-XML document is, e.g. keeping the image referenced in @imageFilename if the PAGE-XML document is derived from another PAGE-XML document. However, I cannot test this, since I don't have any test data that follows this convention we agreed on in the last Tech Call (that AlternativeImages should be written to the fileGrp of the PAGE-XML that references them).

Yes, this is a hen-or-egg problem. I think we could either start a feature branch in core and at least one preprocessing module to test this realistically, or add a pseudo-processor in the test section here (perhaps derived from the new dummy processor) which produces a dummy AlternativeImage via image_from_segment and subsequent save_image_file.

This issue to track progress on that, without blocking #471.

@bertsky
Copy link
Collaborator

bertsky commented Aug 21, 2020

We had #530 and PRs in all modules – can this be closed?

Or do we wait until ocrd_im6convert, ocrd_pagetopdf and other bashlib processors do the same fix as OCR-D/ocrd_olena#68, or based on #571?

@kba
Copy link
Member Author

kba commented Aug 21, 2020

AFAICS only bashlib and bashlib-based processors need further work to properly support the convention. So I think we can close and track progress on bashlib in #571.

@kba kba closed this as completed Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants