Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bashlib: better tooling required to handle PAGE/images in same fileGrp #571

Closed
kba opened this issue Aug 21, 2020 · 4 comments
Closed

bashlib: better tooling required to handle PAGE/images in same fileGrp #571

kba opened this issue Aug 21, 2020 · 4 comments
Assignees

Comments

@kba
Copy link
Member

kba commented Aug 21, 2020

c.f. https://github.com/OCR-D/ocrd_olena/pull/68/files this should be easier.

@bertsky
Copy link
Collaborator

bertsky commented Aug 21, 2020

…and core can also be more efficient!

This is probably not much more than a different mode for the find command: add the option --by-page to yield at most one file per pageId, preferably mimetype PAGE, or "image/*", but failing if there are more than 1 PAGE or image files. (Failure could mean simply skip that pageId, or exiting.)

IMO the best option would be to have a shared, fast implementation for both this CLI option and Processor.input_files.

@bertsky
Copy link
Collaborator

bertsky commented Dec 2, 2021

Or expose Processor.input_files directly to bashlib.

@kba
Copy link
Member Author

kba commented Dec 8, 2021

Since we now have ocrd bashlib input-files is this solved?

@bertsky
Copy link
Collaborator

bertsky commented Dec 8, 2021

Yes (just forgot to link).

@bertsky bertsky closed this as completed Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants