[16.0][FIX] sign_oca Fix sign button visibility #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @etobella, |
etobella
approved these changes
Jul 16, 2024
pedrobaeza
reviewed
Jul 16, 2024
Before this commit ------------------ Internal user cannot sign a document if this user's partner is a child of some other partner. Example: User "Pepe Frog" has a partner "Meme Inc, Pepe Frog" set as `user.partner_id`. This is because partner "Meme Inc" is set as a company for the partner "Pepe Frog". So when user Pepe Frog is assigned to a sign request he cannot see the "Sign" button. After this commit ----------------- User can see the "Sign" button and sign documents even if related partner has a parent partner set.
ivs-cetmix
force-pushed
the
16.0-t3810-sign_oca-fix-sign_button_visibility
branch
from
4b2b405
to
8b470aa
Compare
|
Meanwhile another question non related to this PR: |
|
Sure, be my guest |
victoralmau
approved these changes
Jul 17, 2024
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at 13ddd1d. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit
Internal user cannot sign a document if this user's partner is a child of some other partner.
Example:
User "Pepe Frog" has a partner "Meme Inc, Pepe Frog" set as
user.partner_id. This is because partner "Meme Inc" is set as a company for the partner "Pepe Frog". So when user Pepe Frog is assigned to a sign request he cannot see the "Sign" button.After this commit
User can see the "Sign" button and sign documents even if related partner has a parent partner set.
This highly likely should close #54