[16.0] to_sign being set False incorrectly, sign button hidden from request form

[WispOfTheWinds]

Module

sign_oca_request

Describe the bug

Haven't dug into why exactly this is happening, but to_sign is False when it shouldn't be, causing the Sign button to be invisible. I just removed the check as a stop gap as the check for state != sent does well enough until the _compute_to_sign function can be fixed.

To Reproduce

Affected versions:
Introduced in 9d9a39f?

Steps to reproduce the behavior:

1. Create/send sign request
2. Sign button not present in form or tree view

Expected behavior
Sign button visible in sign request form and tree views

Additional context
Debian 12 with nightly Odoo CE package

[ivs-cetmix]

Hey @WispOfTheWinds could you please do a functional review of #55 and check if it solves your issue?

[WispOfTheWinds]

Still no-go. I hadn't initially noticed that the sign button doesn't work even if I do force it to be visible. Use case is exactly as described in #55.

[WispOfTheWinds]

Poking around some more, the Sign button in SignOcaRequestSignature, accessed from the systray is working correctly, so #55 did the trick for that part. The Sign buttons in SignOcaRequest are never visible and do not function if they are forced to be visible. Not sure if this is just dead code and the use case is intended.

Probably a separate issue, but the UI for the systray button needs to be cleaned up a bit. It's difficult to determine which document is which off the bat.