[17.0][MIG] mis_builder #607

mpascuall · 2024-04-30T06:37:16Z

Module migrated to version 17.0

cc https://github.com/APSL 154544

@miquelalzanillas @lbarry-apsl @javierobcn @peluko00 please review

Currently translated at 100.0% (281 of 281 strings) Translation: mis-builder-16.0/mis-builder-16.0-mis_builder Translate-URL: https://translation.odoo-community.org/projects/mis-builder-16-0/mis-builder-16-0-mis_builder/pt_BR/

Resolve a permission issue when creating report periods with a user without admin rights.

javierobcn

Works well

etobella

Tested on runboat and seems to work well, @sbidoul Can we ask for your opinion?

sbidoul · 2024-05-07T16:56:38Z

I'll have a look soon.

I've renamed the PR title :) Can you also reword the migration commit?

Also, can you rebase without 62359ca? This was for python 3.9 support but Odoo 17 does not support it.

sbidoul · 2024-05-07T16:58:05Z

/ocabot migration mis_builder

OCA-git-bot · 2024-05-07T17:00:02Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

sbidoul

Hi, thanks for working on this migration. Here is a first round of comments.

mis_builder/models/mis_report.py

mis_builder/static/src/components/mis_report_widget.xml

mis_builder/tests/test_aep.py

Currently translated at 76.8% (216 of 281 strings) Translation: mis-builder-16.0/mis-builder-16.0-mis_builder Translate-URL: https://translation.odoo-community.org/projects/mis-builder-16-0/mis-builder-16-0-mis_builder/it/

Currently translated at 99.6% (280 of 281 strings) Translation: mis-builder-16.0/mis-builder-16.0-mis_builder Translate-URL: https://translation.odoo-community.org/projects/mis-builder-16-0/mis-builder-16-0-mis_builder/sv/

Currently translated at 100.0% (281 of 281 strings) Translation: mis-builder-16.0/mis-builder-16.0-mis_builder Translate-URL: https://translation.odoo-community.org/projects/mis-builder-16-0/mis-builder-16-0-mis_builder/sv/

Currently translated at 76.8% (216 of 281 strings) Translation: mis-builder-16.0/mis-builder-16.0-mis_builder Translate-URL: https://translation.odoo-community.org/projects/mis-builder-16-0/mis-builder-16-0-mis_builder/it/

Currently translated at 100.0% (281 of 281 strings) Translation: mis-builder-16.0/mis-builder-16.0-mis_builder Translate-URL: https://translation.odoo-community.org/projects/mis-builder-16-0/mis-builder-16-0-mis_builder/it/

sbidoul · 2024-05-22T10:31:18Z

mis_builder/static/src/components/mis_report_widget.xml

@@ -13,8 +13,7 @@
                        </div>
                        <div class="oe_mis_builder_cp_right_bottom">
                            <div class="oe_mis_builder_filter_buttons">
-                                <FilterMenu t-if="showSearchBar" />
-                                <DatePicker
+                                <DateTimePicker


This looks likes this, with the full calendar being displayed:

It should be a date field with the calendar drop down.

Also I don't think we should use DateTime here, a Date is better.

mis_builder/tests/test_aep.py

sbidoul · 2024-05-23T09:35:52Z

mis_builder/static/src/components/mis_report_widget.xml

                                    t-if="showPivotDate"
+                                    onChange="onDateTimeChanged.bind(this)"


Does this some sort of binding to state.pivot_date?

Yes, it works exactly as v16. The called function is this one:
onDateTimeChanged(ev) { this.state.pivot_date = ev; this.refresh(); }

There is something missing, because in 16, you could set the Base Date on the report form, and it was preserved when clicking Preview.

With this branch, it does not appear in preview. You can check on runboat.

Fixed. In v16 the DatePicker date attribute was setted with state.pivot_date value. Since DateTimeInput doesnt have this attribute i setted it in value.

mis_builder/tests/test_aep.py

sbidoul · 2024-05-24T16:30:21Z

Ah, another thing, the button box on the report instance form does not look right:

Probably something with the classes on the button box div.

mpascuall · 2024-05-27T10:32:39Z

Ah, another thing, the button box on the report instance form does not look right:

Probably something with the classes on the button box div.

Fixed

mpascuall · 2024-06-10T08:42:56Z

Any updates on this? @sbidoul

sbidoul · 2024-06-10T08:47:02Z

@mpascuall To me the buttons are still misplaced. In v16 they are on the right. I have not had time to look for a correct solution for this. But the oe_right oe_button_box classes we use here don't seem to work correctly in v17. Also it seems weird to add a btn class on button tags, but again I've not looked closely yet.

mpascuall · 2024-06-12T11:08:08Z

@mpascuall To me the buttons are still misplaced. In v16 they are on the right. I have not had time to look for a correct solution for this. But the oe_right oe_button_box classes we use here don't seem to work correctly in v17. Also it seems weird to add a btn class on button tags, but again I've not looked closely yet.

Fixed, could you check it again please?

HaraldPanten · 2024-06-20T16:41:31Z

@sbidoul Can our team help you in anything with this module? I'm sure it's close to be merged 😉

sbidoul · 2024-06-20T19:49:43Z

Yes, it's close. I'll review the latest changes after my holidays. Also check if it works in wizard mode.

HaraldPanten · 2024-06-21T07:27:33Z

Yes, it's close. I'll review the latest changes after my holidays. Also check if it works in wizard mode.

Nice. Enjoy your holidays 👍

sbidoul

Looks good now. Many thanks!

sbidoul · 2024-07-08T12:46:00Z

/ocabot merge nobump

OCA-git-bot · 2024-07-08T12:46:07Z

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 17.0-ocabot-merge-pr-607-by-sbidoul-bump-nobump, awaiting test results.

OCA-git-bot · 2024-07-08T12:50:50Z

Congratulations, your PR was merged at 244aded. Thanks a lot for contributing to OCA. ❤️

sbidoul and others added 4 commits April 30, 2024 08:33

[TRN] remove fr_FR.po

9ca4bb5

Translated using Weblate (Portuguese (Brazil))

0229644

Currently translated at 100.0% (281 of 281 strings) Translation: mis-builder-16.0/mis-builder-16.0-mis_builder Translate-URL: https://translation.odoo-community.org/projects/mis-builder-16-0/mis-builder-16-0-mis_builder/pt_BR/

[FIX] mis_builder: add sudo to access field_id due missing permissions

fde3c4e

Resolve a permission issue when creating report periods with a user without admin rights.

[BOT] post-merge updates

b57d250

mpascuall changed the title ~~17.0][FIX] mis_builder: Fix Version~~ [17.0][FIX] mis_builder: Fix Version Apr 30, 2024

mpascuall force-pushed the 17.0-mig-mis_builder branch from d885f2c to 593e6d0 Compare May 6, 2024 13:48

mpascuall mentioned this pull request May 6, 2024

[17.0][MIG] l10n_es_mis_report: Migration to 17.0 OCA/l10n-spain#3570

Merged

1 task

mpascuall force-pushed the 17.0-mig-mis_builder branch from 593e6d0 to 9773d66 Compare May 6, 2024 16:04

mpascuall mentioned this pull request May 6, 2024

Migration to version 17.0 #582

Closed

3 tasks

javierobcn approved these changes May 7, 2024

View reviewed changes

etobella approved these changes May 7, 2024

View reviewed changes

OCA-git-bot added the approved label May 7, 2024

sbidoul changed the title ~~[17.0][FIX] mis_builder: Fix Version~~ [17.0][MIG mis_builder May 7, 2024

OCA-git-bot added this to the 17.0 milestone May 7, 2024

OCA-git-bot added the ready to merge label May 7, 2024

sbidoul self-assigned this May 7, 2024

sbidoul removed approved ready to merge labels May 7, 2024

sbidoul changed the title ~~[17.0][MIG mis_builder~~ [17.0][MIG] mis_builder May 7, 2024

sbidoul requested changes May 8, 2024

View reviewed changes

OCA-git-bot and others added 7 commits May 9, 2024 08:23

[BOT] post-merge updates

457d15d

Translated using Weblate (Italian)

15942ce

Currently translated at 76.8% (216 of 281 strings) Translation: mis-builder-16.0/mis-builder-16.0-mis_builder Translate-URL: https://translation.odoo-community.org/projects/mis-builder-16-0/mis-builder-16-0-mis_builder/it/

Translated using Weblate (Swedish)

075baea

Currently translated at 99.6% (280 of 281 strings) Translation: mis-builder-16.0/mis-builder-16.0-mis_builder Translate-URL: https://translation.odoo-community.org/projects/mis-builder-16-0/mis-builder-16-0-mis_builder/sv/

Translated using Weblate (Swedish)

4281d98

Currently translated at 100.0% (281 of 281 strings) Translation: mis-builder-16.0/mis-builder-16.0-mis_builder Translate-URL: https://translation.odoo-community.org/projects/mis-builder-16-0/mis-builder-16-0-mis_builder/sv/

Translated using Weblate (Swedish)

063dbc2

Currently translated at 100.0% (281 of 281 strings) Translation: mis-builder-16.0/mis-builder-16.0-mis_builder Translate-URL: https://translation.odoo-community.org/projects/mis-builder-16-0/mis-builder-16-0-mis_builder/sv/

Translated using Weblate (Italian)

68fa1a5

Currently translated at 76.8% (216 of 281 strings) Translation: mis-builder-16.0/mis-builder-16.0-mis_builder Translate-URL: https://translation.odoo-community.org/projects/mis-builder-16-0/mis-builder-16-0-mis_builder/it/

Translated using Weblate (Italian)

2b3112b

Currently translated at 100.0% (281 of 281 strings) Translation: mis-builder-16.0/mis-builder-16.0-mis_builder Translate-URL: https://translation.odoo-community.org/projects/mis-builder-16-0/mis-builder-16-0-mis_builder/it/

sbidoul reviewed May 22, 2024

View reviewed changes

mis_builder/tests/test_aep.py Outdated Show resolved Hide resolved

sbidoul reviewed May 22, 2024

View reviewed changes

mis_builder/tests/test_aep.py Outdated Show resolved Hide resolved

mpascuall force-pushed the 17.0-mig-mis_builder branch from 1e4aff3 to 01bdeaf Compare May 23, 2024 09:29

sbidoul reviewed May 23, 2024

View reviewed changes

mis_builder/tests/test_aep.py Outdated Show resolved Hide resolved

mpascuall force-pushed the 17.0-mig-mis_builder branch 2 times, most recently from caeec94 to 17b3f97 Compare May 23, 2024 09:51

mpascuall force-pushed the 17.0-mig-mis_builder branch from 17b3f97 to f550423 Compare May 27, 2024 10:30

mpascuall requested a review from sbidoul June 4, 2024 07:30

[MIG] mis_builder: Migration to 17.0

0ca865c

mpascuall force-pushed the 17.0-mig-mis_builder branch from f550423 to 0ca865c Compare June 12, 2024 11:07

vdewulf mentioned this pull request Jul 1, 2024

mis_builder_budget not migrated #612

Closed

sbidoul approved these changes Jul 8, 2024

View reviewed changes

OCA-git-bot added the approved label Jul 8, 2024

OCA-git-bot added the bot is merging ⏳ label Jul 8, 2024

OCA-git-bot merged commit 820e08a into OCA:17.0 Jul 8, 2024
5 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Jul 8, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[17.0][MIG] mis_builder #607

[17.0][MIG] mis_builder #607

mpascuall commented Apr 30, 2024 •

edited

Loading

javierobcn left a comment

etobella left a comment

sbidoul commented May 7, 2024

sbidoul commented May 7, 2024

OCA-git-bot commented May 7, 2024

sbidoul left a comment •

edited

Loading

sbidoul May 22, 2024

mpascuall May 23, 2024

sbidoul May 23, 2024

mpascuall May 23, 2024

sbidoul May 24, 2024

mpascuall May 27, 2024

sbidoul commented May 24, 2024

mpascuall commented May 27, 2024

mpascuall commented Jun 10, 2024

sbidoul commented Jun 10, 2024

mpascuall commented Jun 12, 2024 •

edited

Loading

HaraldPanten commented Jun 20, 2024

sbidoul commented Jun 20, 2024

HaraldPanten commented Jun 21, 2024 •

edited

Loading

sbidoul left a comment

sbidoul commented Jul 8, 2024

OCA-git-bot commented Jul 8, 2024

OCA-git-bot commented Jul 8, 2024

[17.0][MIG] mis_builder #607

[17.0][MIG] mis_builder #607

Conversation

mpascuall commented Apr 30, 2024 • edited Loading

javierobcn left a comment

Choose a reason for hiding this comment

etobella left a comment

Choose a reason for hiding this comment

sbidoul commented May 7, 2024

sbidoul commented May 7, 2024

OCA-git-bot commented May 7, 2024

sbidoul left a comment • edited Loading

Choose a reason for hiding this comment

sbidoul May 22, 2024

Choose a reason for hiding this comment

mpascuall May 23, 2024

Choose a reason for hiding this comment

sbidoul May 23, 2024

Choose a reason for hiding this comment

mpascuall May 23, 2024

Choose a reason for hiding this comment

sbidoul May 24, 2024

Choose a reason for hiding this comment

mpascuall May 27, 2024

Choose a reason for hiding this comment

sbidoul commented May 24, 2024

mpascuall commented May 27, 2024

mpascuall commented Jun 10, 2024

sbidoul commented Jun 10, 2024

mpascuall commented Jun 12, 2024 • edited Loading

HaraldPanten commented Jun 20, 2024

sbidoul commented Jun 20, 2024

HaraldPanten commented Jun 21, 2024 • edited Loading

sbidoul left a comment

Choose a reason for hiding this comment

sbidoul commented Jul 8, 2024

OCA-git-bot commented Jul 8, 2024

OCA-git-bot commented Jul 8, 2024

mpascuall commented Apr 30, 2024 •

edited

Loading

sbidoul left a comment •

edited

Loading

mpascuall commented Jun 12, 2024 •

edited

Loading

HaraldPanten commented Jun 21, 2024 •

edited

Loading