-
-
Notifications
You must be signed in to change notification settings - Fork 520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][MIG] l10n_es_mis_report: Migration to 17.0 #3570
Conversation
3b36b0e
to
b4e7c4b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works good, tested in runboat
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well
@manuelregidor @Tisho99 could u review please? |
/ocabot migration l10n_es_mis_report |
Wouldn't it be better to put the changes related to the readme files in the module l10n_es_vat_book in an idependent commit? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technical review. LGTM
ad8f7fe
to
8519d41
Compare
Fixed that. Changes in l10n_es_vat_book are now deleted |
@mpascuall Puedes hacer rebase? |
8519d41
to
92690e3
Compare
This PR has the |
El rebase no es correcto y hay conflictos. |
de cuentas de mis_builder.
ciertas cuentas al pasivo o activo según el signo del saldo en lugar de llevar todo el debe y todo el haber.
For the balance sections where the sum of debtor/creditor balances is needed, with this new expression we can get the interpreted result.
The account code 1146 [1] is not yet on the Spanish CoA, but it was created due to a 2014 law [2] for a special provision case. By chance, a mistake putting the same balance code as expression, that inexisting account was mapped to an incorrect place. On this commit, we remove the incorrect expression, and add a new section under "III. Reservas" for reflecting this balance according [3]. [1] https://www.supercontable.com/informacion/Contabilidad/Cuenta_1146_Reserva_de_Capitalizacion..html [2] https://www.supercontable.com/informacion/impuesto_sociedades/Articulo_25_Ley_27-2014-_de_27_de_noviembre-_del_.html [3] https://www.supercontable.com/envios/articulos/BOLETIN_SUPERCONTABLE_12_2017_Contenido_General_2.htm
Currently translated at 12.1% (37 of 304 strings) Translation: l10n-spain-15.0/l10n-spain-15.0-l10n_es_mis_report Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-15-0/l10n-spain-15-0-l10n_es_mis_report/ca/
…idas y ganancias de pymes'con nuevo formato de registro mercantil
Currently translated at 100.0% (310 of 310 strings) Translation: l10n-spain-15.0/l10n-spain-15.0-l10n_es_mis_report Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-15-0/l10n-spain-15-0-l10n_es_mis_report/ca/
Currently translated at 10.0% (31 of 310 strings) Translation: l10n-spain-15.0/l10n-spain-15.0-l10n_es_mis_report Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-15-0/l10n-spain-15-0-l10n_es_mis_report/es/
Currently translated at 10.3% (32 of 310 strings) Translation: l10n-spain-16.0/l10n-spain-16.0-l10n_es_mis_report Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-16-0/l10n-spain-16-0-l10n_es_mis_report/es/
Currently translated at 100.0% (310 of 310 strings) Translation: l10n-spain-16.0/l10n-spain-16.0-l10n_es_mis_report Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-16-0/l10n-spain-16-0-l10n_es_mis_report/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: l10n-spain-16.0/l10n-spain-16.0-l10n_es_mis_report Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-16-0/l10n-spain-16-0-l10n_es_mis_report/
92690e3
to
301adda
Compare
301adda
to
bcbe83c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ocabot merge nobump
Hey, thanks for contributing! Proceeding to merge this for you. |
Congratulations, your PR was merged at 79a948f. Thanks a lot for contributing to OCA. ❤️ |
Module migrated to version 17.0
cc https://github.com/APSL 154488
@miquelalzanillas @lbarry-apsl @javierobcn @peluko00 please review
Depends on: