fix(desktop): clear consistent advisory smoke baseline failures - #170
Merged
Conversation
Product: unread live channel subs use CHANNEL_LIVE_BACKLOG_GRACE_SECONDS so lagged self roots reach authoredRootIds (channel-activity popover); getAgentObserverSnapshot only forces connecting when restored events lack live contact so empty agents show "No ACP activity yet". Harness: evidence Reject scopes to the timeline card (thread-head dual render is intentional); sticky day divider seeds two recent local days before open so fixtures match production window + grace filters.
oscarlehuu
force-pushed
the
fix/smoke-baseline-cleanup
branch
from
August 12, 2026 08:33
6509c67 to
251e6f1
Compare
This was referenced Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Advisory Desktop Smoke on
mainhad a consistent fail set across the two most recent completed CI runs used as baseline:#155middle-page scroll)Target families (intersection, not one-run flakes):
evidence-reactions.spec.ts:46evidence-reaction-rejectedresolves 2 nodes after Rejectchannels.spec.ts:1951message-timeline-day-groupcount 0 after bulk live emitchannels.spec.ts:2108"No ACP activity yet"channel-activity-popover.spec.ts(multiple)No GitHub issue — intentional baseline cleanup PR.
Approach (per-spec)
evidence-reactionsRejectonReply→ thread panel mounts same message as head; dual card is product-correctmessage-timelinechannelssticky day divideremitLive: false) so head window loads them withhasMore:false→ both virtualized day dividers provechannelsagent activity emptygetAgentObserverSnapshotmapsopen+ no live contact →connectingeven with zero events → infinite skeletonconnectingonly whenevents.length > 0without live contact (restored/replay path). Empty + open → idle openchannel-activity-popoversince: now; self roots atnow-20dropped beforeonSelfChannelMessage→authoredRootIdsnever grows → bob replies fail notify gateCHANNEL_LIVE_BACKLOG_GRACE_SECONDSas timelinebuildChannelLiveFilterSeams:
useLiveChannelUpdatesunread live filter;getAgentObserverSnapshot/observerRelayStore; smoke harness timestamps/selectors only.Tests
Local (macOS,
--project=smoke --retries=0afterpnpm --filter buzz build:e2e):evidence-reactions.spec.ts— 3 passedchannels.spec.tssticky day + agent activity — 2 passedchannel-activity-popover.spec.ts— 10 passedobserverPerAgentTelemetry.test.mjs— 10 passed (added empty+open idle case)pnpm typecheck,biome checkon touched filesAcceptance on this PR: targeted smoke shards green. Integration lane drift is out of scope.
Docs
docs/crew/STATE.md— advisory smoke baseline cleanup note.Risk
Exclusions
channel-agent-presence(test(desktop): emit an authorizable 46040 in the channel presence spec #141),scroll-history(fix(desktop): restore fast middle-page scroll coverage setup (#155) #166/scroll-history.spec.ts:1281 — fast middle-page scroll settles with ~half the required mounted coverage #155),relay-reconnect(fix(desktop): keep interstitial older pages across reconnect freeze (#154) #167/relay-reconnect.spec.ts:617 — pre-disconnect message disappears from the timeline after a 260-message reconnect backfill #154).e2eBridge.tsrelay-mode handler edits (sibling feat(e2e): remaining bridge mutations relay-aware (Fixes #144) #168 lane).