Skip to content

Updates radiation docs#285

Merged
navidcy merged 15 commits intomainfrom
ncc/radiation-docs
Dec 16, 2025
Merged

Updates radiation docs#285
navidcy merged 15 commits intomainfrom
ncc/radiation-docs

Conversation

@navidcy
Copy link
Copy Markdown
Member

@navidcy navidcy commented Dec 15, 2025

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@navidcy navidcy requested review from giordano and glwagner and removed request for glwagner December 15, 2025 23:18
@navidcy navidcy added documentation 📜 improvements or additions to documentation radiation ☀️ labels Dec 15, 2025
@navidcy navidcy requested a review from glwagner December 15, 2025 23:19
@navidcy navidcy marked this pull request as ready for review December 15, 2025 23:19
Comment thread docs/src/radiative_transfer.md
Comment thread docs/src/api.md
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this works

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Locally it does

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, wait, you define the module names in docs/make.jl, this may work then!

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you think of a cleaner/better way to do it then go for it!

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I think this is the strategy @asinghvi17 suggested the other day on Slack.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That probably works. Autodocs is also executed in Main iirc, so you can just run Base.get_extension within there if you want extra clarity.

@navidcy navidcy requested a review from glwagner December 16, 2025 03:40
@navidcy navidcy merged commit 07e2ec9 into main Dec 16, 2025
11 checks passed
@navidcy navidcy deleted the ncc/radiation-docs branch December 16, 2025 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation 📜 improvements or additions to documentation radiation ☀️

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants