Extension to RRTMGP.jl and implement RadiativeTransferModel#176
Extension to RRTMGP.jl and implement RadiativeTransferModel#176
RRTMGP.jl and implement RadiativeTransferModel#176Conversation
glwagner
changed the title
RRTMGP.jlRRTMGP.jl and implement grey radiative transfer model
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
Co-authored-by: Navid C. Constantinou <navidcy@users.noreply.github.com>
Co-authored-by: Navid C. Constantinou <navidcy@users.noreply.github.com>
Co-authored-by: Navid C. Constantinou <navidcy@users.noreply.github.com>
Co-authored-by: Navid C. Constantinou <navidcy@users.noreply.github.com>
Co-authored-by: Mosè Giordano <765740+giordano@users.noreply.github.com>
|
| update_radiation!(radiation, model) = nothing | ||
|
|
||
| """ | ||
| RadiativeTransferModel(grid, constants, optical_thickness; kw...) |
There was a problem hiding this comment.
In the RRTMGP extension. Yeah, we should add an actual method that throws an informative error
| The gray atmosphere optical thickness follows the parameterization by [OGormanSchneider2008](@citet): | ||
|
|
||
| ```math | ||
| τ_{lw} = α \frac{Δp}{p} \left[ f_l \frac{p}{p_0} + 4 (1 - f_l) \left(\frac{p}{p_0}\right)^4 \right] \left[ τ_e + (τ_p - τ_e) \sin^2 φ \right] |
There was a problem hiding this comment.
This is slightly different from the expression in the paper by O'Gorman & Schneider. There is an extra there is an extra Δp/p. Is this OK?
There was a problem hiding this comment.
Also there is a 4 x (1 - f_l) while in the paper there isn't any 4x
There was a problem hiding this comment.
might also be worth checking the RRTMGP source but not essential
There was a problem hiding this comment.
Where does the SW optical length expression comes from? I can't find it in the paper...
There was a problem hiding this comment.
If you look eq. (7) -> (8) seems like a derivative, that is (p/p0)^2 -> 2 (p/p0) Δp/p0
But from (5) -> (6) the terms (p/p0) and (p/p0)^4 didn't become 1 and 4(p/p0)^3 but rather (p/p0) and 4(p/p0)^4.
strange?
There was a problem hiding this comment.
Ok I see it. It is written confusingly. The whole expression is divided by
If i were to write equation 6, I would write it
alternatively we can define
There was a problem hiding this comment.
Let's rewrite it like this in our docs and just add a note that "this is the same as eq. X in such & such paper"
There was a problem hiding this comment.
I thikn that's a good idea. Also maybe there is a better gray optics model we can come up with!
glwagner
changed the title
RRTMGP.jl and implement GrayRadiativeTransferModelRRTMGP.jl and implement RadiativeTransferModel
3 participants
Continues from #31
Mostly agent-generated, so needs a bit of work. Starting point is going to be the user interface in
docs/src/radiative_transfer.md, which will perform some column calculations.The key elements right now are:
RadiativeTransferModel. Eventually this should support other solvers besides RRTMGPAtmosphereModel.radiative_transfer(could call thisradiationtoo)compute!(rtm::RadiativeTransferModel, model::AtmosphereModel)or something like thatI would also like the
RadiativeTransferModelto be invokable without being embedded inside the AtmosphereModel. This will be useful for coupling.