Skip to content

Conversation

@nkolev92
Copy link
Member

@nkolev92 nkolev92 commented May 21, 2025

Bug

Related: NuGet/Home#14196

Description

Spec: NuGet/Home#14325

This captures the first part which was something we reviewed with partners during earlier discussion.
https://github.com/NuGet/Home/blob/dev-nkolev92-packagepruning-directrefs/accepted/2025/PrunePackageReference-with-direct-PackageReference.md#how-do-we-tell-the-customers-we-want-them-to-remove-a-packagereference

The part about direct pruning is still a work in progress.

  • Remove the raising of NU1510 from the resolver code. This is something that can be calculated independent of the resolved graph.
  • By moving this logic out of the core resolver code, it allows us to more easily make decisions based on multiple frameworks.

PR Checklist

  • Meaningful title, helpful description and a linked NuGet/Home issue
  • Added tests
  • Link to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc. - Update the NU1510 documentation Home#14330

@nkolev92 nkolev92 marked this pull request as ready for review May 21, 2025 17:56
@nkolev92 nkolev92 requested a review from a team as a code owner May 21, 2025 17:56
jeffkl
jeffkl previously approved these changes May 21, 2025
jeffkl
jeffkl previously approved these changes May 21, 2025
@nkolev92 nkolev92 force-pushed the dev-nkolev92-improveNU1510Heuristic branch from 49b3a4e to 0d226e8 Compare May 22, 2025 16:39
@nkolev92 nkolev92 force-pushed the dev-nkolev92-improveNU1510Heuristic branch from 0d226e8 to 2a1210e Compare May 22, 2025 16:39
@nkolev92 nkolev92 requested review from jeffkl and zivkan May 22, 2025 19:26
@nkolev92 nkolev92 merged commit 58c248e into dev May 22, 2025
20 of 21 checks passed
@nkolev92 nkolev92 deleted the dev-nkolev92-improveNU1510Heuristic branch May 22, 2025 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants