Reduce allocations under UnresolvedMessages.GetMessageAsync #6264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method shows as 0.6% (95 MB) of all VS allocations from VS start until opening the file in the CSharpEditingTest speedometer test. I think the changes in this PR should get rid of the majority of those allocations. The primary change here is to not use a SortedSet, but instead have the code do the sorting when it's needed. The SortedSet ctor allocates a fair bit, and each node in the set requires an allocation for the wrapping node. As for the concern of now needing to walk the whole collection in GetBestMatch as the collection is no longer sorted, the old code was doing that anyways. Both the FirstOrDefault and Last methods are IEnumerable extensions that potentially walk the full collection.
dotnet-policy-service
bot
added
the
Community
microsoft-github-policy-service
bot
added
the
Community
|
Test insertion based on commit 1 from which to get speedometer numbers: https://devdiv.visualstudio.com/DevDiv/_git/VS/pullrequest/610229 |
|
/azp run NuGet.Client-PrivateDev |
|
No pipelines are associated with this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#14094
Description
Reduce allocations under UnresolvedMessages.GetMessageAsync
This method shows as 0.6% (95 MB) of all VS allocations from VS start until opening the file in the CSharpEditingTest speedometer test. I think the changes in this PR should get rid of the majority of those allocations.
The primary change here is to not use a SortedSet, but instead have the code do the sorting when it's needed. The SortedSet ctor allocates a fair bit, and each node in the set requires an allocation for the wrapping node.
As for the concern of now needing to walk the whole collection in GetBestMatch as the collection is no longer sorted, the old code was doing that anyways. Both the FirstOrDefault and Last methods are IEnumerable extensions that potentially walk the full collection.
PR Checklist