Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UnresolvedMessages.GetMessageAsync is allocating more heavily than necessary #14094

Open
ToddGrun opened this issue Feb 11, 2025 · 0 comments · May be fixed by NuGet/NuGet.Client#6264
Open

UnresolvedMessages.GetMessageAsync is allocating more heavily than necessary #14094

ToddGrun opened this issue Feb 11, 2025 · 0 comments · May be fixed by NuGet/NuGet.Client#6264
Labels
Priority:2 Issues for the current backlog. Tenet:Performance Performance issues Type:Bug

Comments

@ToddGrun
Copy link

NuGet Product Used

Other/NA

Product Version

VS 17.14

Worked before?

No response

Impact

It bothers me. A fix would be nice

Repro Steps & Context

CSharpEditingTests.ScrollingAndTyping speedometer test shows 0.6% of all VS allocations from VS start until opening the file under UnresolvedMessages.GetMessageAsync.

The primary issue here is the use of a SortedSet as it's ctor allocates a fair bit, and each node in the set requires an allocation for the wrapping node. Instead, the code could be modified to not require the collection to be sorted without any performance impact.

Image

Verbose Logs

@Nigusu-Allehu Nigusu-Allehu added Tenet:Performance Performance issues and removed Triage:Untriaged labels Feb 15, 2025
@jeffkl jeffkl added the Priority:2 Issues for the current backlog. label Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:2 Issues for the current backlog. Tenet:Performance Performance issues Type:Bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants