Skip to content

use using for disposable memorystream in NuGetPackageFileService #3878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rrelyea merged 1 commit into from
Feb 1, 2021
Merged

use using for disposable memorystream in NuGetPackageFileService #3878

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 17 additions & 21 deletions src/NuGet.Clients/NuGet.PackageManagement.UI/Models/PackageItemListViewModel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@

// Copyright (c) .NET Foundation. All rights reserved.
// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.

Expand Down Expand Up @@ -548,28 +547,25 @@ private async Task FetchIconAsync()
// to support downloading on a worker thread, we need to download the image
// data and put into a memorystream. Then have the BitmapImage decode the
// image from the memorystream.
#pragma warning disable CA2000 // Dispose objects before losing scope
var memoryStream = new MemoryStream();
#pragma warning restore CA2000 // Dispose objects before losing scope

// Cannot call CopyToAsync as we'll get an InvalidOperationException due to CheckAccess() in next line.
stream.CopyTo(memoryStream);
iconBitmapImage.StreamSource = memoryStream;

try
using (var memoryStream = new MemoryStream())
{
FinalizeBitmapImage(iconBitmapImage);
iconBitmapImage.Freeze();
IconBitmap = iconBitmapImage;
BitmapStatus = IconBitmapStatus.FetchedIcon;
}
catch (Exception ex) when (IsHandleableBitmapEncodingException(ex))
{
IconBitmap = Images.DefaultPackageIcon;
BitmapStatus = IconBitmapStatus.DefaultIconDueToDecodingError;
}
// Cannot call CopyToAsync as we'll get an InvalidOperationException due to CheckAccess() in next line.
stream.CopyTo(memoryStream);
iconBitmapImage.StreamSource = memoryStream;

memoryStream.Dispose();
try
{
FinalizeBitmapImage(iconBitmapImage);
iconBitmapImage.Freeze();
IconBitmap = iconBitmapImage;
BitmapStatus = IconBitmapStatus.FetchedIcon;
}
catch (Exception ex) when (IsHandleableBitmapEncodingException(ex))
{
IconBitmap = Images.DefaultPackageIcon;
BitmapStatus = IconBitmapStatus.DefaultIconDueToDecodingError;
}
}
}
else
{
Expand Down