use using for disposable memorystream in NuGetPackageFileService #3878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rrelyea
requested review from
aortiz-msft,
dominoFire,
donnie-msft,
dtivel,
heng-liu,
jebriede,
kartheekp-ms,
nkolev92,
sbanni,
zivkan and
zkat
sbanni
approved these changes
Jan 30, 2021
src/NuGet.Clients/NuGet.PackageManagement.UI/Models/PackageItemListViewModel.cs
Show resolved
Hide resolved
erdembayar
approved these changes
Jan 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#10503
Regression? yes, introduced yesterday
Description
Use using for disposable memory stream. Also could use Finally in try/catch block, but this is cleaner.
PR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation