fix(codex): honor run budgets and prevent false terminal success - #98940
Open
danhayman wants to merge 4 commits into
Open
fix(codex): honor run budgets and prevent false terminal success#98940danhayman wants to merge 4 commits into
danhayman wants to merge 4 commits into
Conversation
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix Codex app-server turns being forcibly terminalized after a hardcoded 600 seconds and incorrectly returning interim assistant/progress text as successful final output.
The change:
turn/start;turn/completedcompatibility only for protocol-groundedfinal_answeritems, snapshotting canonical text so later commentary cannot replace it;Reproduction
Multiple native Codex app-server sessions launched with
--run-budget 10800or14400ended at exactly 600 seconds with:The accepted text was an interim progress message and the CLI exited code 0. The defect also reproduced while implementing this fix.
Related upstream context:
turn/completedafter assistant text.This PR addresses the combined deadline, event-classification, and approval-lifecycle bug class.
Verification
Final remediation and independent review evidence includes:
py_compile, andgit diff --checkpassed.44c7ff3aafe37a28495ddf6d5f7afd57cda51688.A broader unrelated test can be environment-sensitive when
/tmpresolves inside a Git workspace; no failure implicated this diff.Deployment
No live gateway was restarted or modified while developing or reviewing this change.