fix(codex): recover app-server text without completion - #58433
Closed
ooiuuii wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #58432
Summary
turn/completedWhy
CodexAppServerSession.run_turn()already records completedagentMessageitems intoresult.final_textandprojected_messages. If the subprocess omitsturn/completedafterward, the previous deadline path still marked the turn as interrupted and timed out, losing the successful completion state.Proof
uv run --extra dev python -m py_compile agent\transports\codex_app_server_session.py tests\agent\transports\test_codex_app_server_session.py$env:TMP='F:\Codex\tmp\pytest-hermes'; $env:TEMP='F:\Codex\tmp\pytest-hermes'; uv run --extra dev pytest tests\agent\transports\test_codex_app_server_session.py -k "final_agent_message_without_turn_completed or deadline_marks_session_for_retirement or post_tool_quiet_watchdog or turn_aborted_marker" -q->4 passed, 55 deselected$env:TMP='F:\Codex\tmp\pytest-hermes'; $env:TEMP='F:\Codex\tmp\pytest-hermes'; uv run --extra dev pytest tests\agent\transports\test_codex_app_server_session.py -q->59 passedDuplicate search
Checked open and closed Hermes PRs/issues for
codex app-server missing turn completed final response,codex app-server turn completed timeout assistant,turn/completed codex final_text, andturn timed out after codex final_text. Existing matches were older Codex Responses stream issues, not this app-server session completion path.