Skip to content

fix(update): only require fleet verification for gateway runtimes #97450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wooyongbin3-cpu wants to merge 1 commit into from
Closed

fix(update): only require fleet verification for gateway runtimes #97450

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion hermes_cli/update_cmd.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10103,7 +10103,14 @@ def _fleet_probe_expected_runtimes(
return True
try:
if pre_update_plan is not None and pre_update_plan.runtimes:
return True
# Only gateway runtimes require fleet verification;
# dashboard/serve-only plans don't need gateway rows.
has_gateway = any(
getattr(r, 'kind', '') == 'gateway'
for r in pre_update_plan.runtimes
)
if has_gateway:
return True
except Exception:
pass
return False
Expand Down