fix(update): only require fleet verification for gateway runtimes - #97450
Closed
wooyongbin3-cpu wants to merge 1 commit into
Closed
wooyongbin3-cpu wants to merge 1 commit into
wooyongbin3-cpu wants to merge 1 commit into
Conversation
The updater was treating any runtime (dashboard, serve) as evidence that gateway fleet verification was needed. This caused `hermes update` to exit 1 even when only a dashboard was running and the update succeeded. The fix filters pre_update_plan.runtimes to only count gateway runtimes as evidence requiring fleet verification. Dashboard/serve-only plans no longer trigger the gateway fleet check. This preserves the fail-closed behavior when a gateway was running while fixing the false positive for dashboard-only setups. Fixes NousResearch#97332 🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com>
Contributor
10 tasks
Collaborator
|
Same fix landed in #103478 (f58fcc8) via the earlier #97350 by @liuhao1024 (cherry-picked with credit). Thanks for the report. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes #97332 by only requiring fleet verification for gateway runtimes, not dashboard/serve runtimes.
Problem
The updater was treating any runtime (dashboard, serve) as evidence that gateway fleet verification was needed. This caused
hermes updateto exit 1 even when only a dashboard was running and the update succeeded.Solution
Filter
pre_update_plan.runtimesto only count gateway runtimes as evidence requiring fleet verification:Dashboard/serve-only plans no longer trigger the gateway fleet check.
Changes
hermes_cli/update_cmd.py: Added gateway-specific filtering in_fleet_probe_expected_runtimes🤖 Generated with Codebuff
Co-Authored-By: Codebuff noreply@codebuff.com