refactor: split adapter and cli cleanup - #939
Closed
kshitijk4poor wants to merge 2 commits into
Closed
Conversation
…or cleanups - Extract _relative_time() to module-level in hermes_cli/main.py (was defined 3x) - Add _run_simple_slash() helper for Discord slash commands (14 of 16 now use it) - Fix build_tool_preview return type annotation (str -> str | None) - Remove redundant `import re` in hermes_state.py methods (already at module level) - Hoist _SANE_PATH to module-level constant in browser_tool.py
…shot cleanup - Extract _send_file_attachment() in Discord adapter, _upload_file() in Slack adapter - Add explicit FileNotFoundError handling in all platform adapters - Remove redundant inline imports in Telegram adapter - Throttle _cleanup_old_screenshots to run at most once per hour
kshitijk4poor
changed the title
teknium1
pushed a commit
that referenced
this pull request
Mar 14, 2026
Salvaged from PR #939 by kshitij. - deduplicate Discord slash command dispatch and local file send helpers - deduplicate Slack file uploads while preserving thread metadata - extract shared CLI session relative-time formatting - hoist browser PATH cleanup constants and throttle screenshot pruning - tidy small type and import cleanups
Contributor
|
Merged via PR #1279. I salvaged the substantive cleanup work onto current main, preserving contributor credit and adapting the newer gateway pieces (notably Slack thread-metadata preservation and Discord/file-helper integration) so it merges cleanly with current behavior. |
teknium1
added a commit
that referenced
this pull request
Mar 14, 2026
refactor: salvage adapter and CLI cleanup from PR #939
angelburgosrosado
pushed a commit
to angelburgosrosado/hermes-agent
that referenced
this pull request
Apr 27, 2026
Salvaged from PR NousResearch#939 by kshitij. - deduplicate Discord slash command dispatch and local file send helpers - deduplicate Slack file uploads while preserving thread metadata - extract shared CLI session relative-time formatting - hoist browser PATH cleanup constants and throttle screenshot pruning - tidy small type and import cleanups
angelburgosrosado
pushed a commit
to angelburgosrosado/hermes-agent
that referenced
this pull request
Apr 27, 2026
…315847fd refactor: salvage adapter and CLI cleanup from PR NousResearch#939
02356abc
pushed a commit
to 02356abc/hermes-agent
that referenced
this pull request
May 14, 2026
Salvaged from PR NousResearch#939 by kshitij. - deduplicate Discord slash command dispatch and local file send helpers - deduplicate Slack file uploads while preserving thread metadata - extract shared CLI session relative-time formatting - hoist browser PATH cleanup constants and throttle screenshot pruning - tidy small type and import cleanups
02356abc
pushed a commit
to 02356abc/hermes-agent
that referenced
this pull request
May 14, 2026
…315847fd refactor: salvage adapter and CLI cleanup from PR NousResearch#939
waefrebeorn
pushed a commit
to waefrebeorn/slermes
that referenced
this pull request
Jul 2, 2026
Salvaged from PR NousResearch#939 by kshitij. - deduplicate Discord slash command dispatch and local file send helpers - deduplicate Slack file uploads while preserving thread metadata - extract shared CLI session relative-time formatting - hoist browser PATH cleanup constants and throttle screenshot pruning - tidy small type and import cleanups
waefrebeorn
pushed a commit
to waefrebeorn/slermes
that referenced
this pull request
Jul 2, 2026
…315847fd refactor: salvage adapter and CLI cleanup from PR NousResearch#939
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Scope
agent/display.py,gateway/platforms/{discord,slack,telegram}.py,hermes_cli/main.py,hermes_state.py,tools/browser_tool.pyrun_agent.py/tests/test_run_agent.pyRelated
Validation
python -m pytest tests/gateway/ -qpython -m pytest tests/test_cli_init.py tests/hermes_cli/test_commands.py -q