Skip to content

refactor: salvage adapter and CLI cleanup from PR #939 - #1279

Merged
teknium1 merged 1 commit into
mainfrom
hermes/hermes-315847fd
Mar 14, 2026
Merged

refactor: salvage adapter and CLI cleanup from PR #939#1279
teknium1 merged 1 commit into
mainfrom
hermes/hermes-315847fd

Conversation

@teknium1

Copy link
Copy Markdown
Contributor

Summary

  • salvage the current-main-safe cleanup work from PR refactor: split adapter and cli cleanup #939 by @kshitijk4poor
  • deduplicate Discord slash command dispatch and local file attachment helpers
  • deduplicate Slack file uploads while preserving thread metadata behavior on current main
  • extract shared CLI session relative-time formatting and hoist browser cleanup constants
  • add screenshot cleanup throttling coverage

Contributor credit

This PR salvages the substantive cleanup work from #939 onto current main with adaptation for newer gateway behavior.

Test plan

  • source /home/teknium/.hermes/hermes-agent/.venv/bin/activate && python -m pytest tests/gateway/test_send_image_file.py tests/gateway/test_slack.py tests/hermes_cli/test_session_browse.py -n0 -q
  • source /home/teknium/.hermes/hermes-agent/.venv/bin/activate && python -m pytest tests/hermes_cli/test_commands.py -n0 -q
  • source /home/teknium/.hermes/hermes-agent/.venv/bin/activate && python -m pytest tests/gateway/test_discord_slash_commands.py -n0 -q
  • source /home/teknium/.hermes/hermes-agent/.venv/bin/activate && python -m pytest tests/ -n0 -q
  • source /home/teknium/.hermes/hermes-agent/.venv/bin/activate && python -m hermes_cli.main chat -q "Reply with OK only."

Salvaged from PR #939 by kshitij.

- deduplicate Discord slash command dispatch and local file send helpers
- deduplicate Slack file uploads while preserving thread metadata
- extract shared CLI session relative-time formatting
- hoist browser PATH cleanup constants and throttle screenshot pruning
- tidy small type and import cleanups
@teknium1
teknium1 force-pushed the hermes/hermes-315847fd branch from 813f516 to 0bb7ed1 Compare March 14, 2026 10:08
@teknium1
teknium1 merged commit 29312a2 into main Mar 14, 2026
1 check passed
@teknium1
teknium1 deleted the hermes/hermes-315847fd branch March 14, 2026 10:10
angelburgosrosado pushed a commit to angelburgosrosado/hermes-agent that referenced this pull request Apr 27, 2026
…315847fd

refactor: salvage adapter and CLI cleanup from PR NousResearch#939
02356abc pushed a commit to 02356abc/hermes-agent that referenced this pull request May 14, 2026
…315847fd

refactor: salvage adapter and CLI cleanup from PR NousResearch#939
waefrebeorn pushed a commit to waefrebeorn/slermes that referenced this pull request Jul 2, 2026
…315847fd

refactor: salvage adapter and CLI cleanup from PR NousResearch#939
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants