Repository navigation
fix: /retry and /undo no longer replay an older message after compaction (#81233, salvage #81234) - #93784
Merged
Conversation
…-final # Conflicts: # tui_gateway/methods_prompt.py # tui_gateway/server.py
…-final # Conflicts: # tests/test_tui_gateway_server.py # tui_gateway/methods_prompt.py # tui_gateway/methods_tools.py
…60821 # Conflicts: # tests/agent/test_reference_handoff_active_turn.py
૮ >ﻌ< ა ci reviewran on 1a95d0d — Merge branch 'pr-81234' into salv/81234-retry-carrier
|
This was referenced Aug 24, 2026
melon-xf
added a commit
to melon-xf/hermes-agent
that referenced
this pull request
Sep 3, 2026
…try-carrier fix: /retry and /undo no longer replay an older message after compaction (NousResearch#81233, salvage NousResearch#81234)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After context compression, /retry on Desktop (and CLI/gateway/TUI) resends an older, wrong message instead of the last thing the user actually asked — and drops the compacted context on the way. Reported live by @gashoUlemsee on X ("/retry in hermes desktop does not resend the last user message. Just picks some message and resends it").
Root cause: compaction can merge the current live ask into the same
role=userrow as the summary scaffold (a "composite carrier"). Since #80622, retry/undo selectors treat every summary-bearing row as scaffolding, so they skip the carrier and land on an older user row — replaying a stale prompt and truncating away the compaction summary.Salvage of #81234 by @poisdahl (fixes #81233). Merged cleanly onto current main with authorship preserved (6 commits).
Changes
user_originated_turn_view) for both composite-carrier layouts (force-user-leading handoff and merged user carrier)Validation
Live repro: base main fires the exact reported symptom through the real
command.dispatchretry surface (the code path Desktop hits over the gateway WS); head resolves it —{"type": "send", "message": "REAL ASK"}with the summary scaffold preserved.Infographic