Repository navigation
Conversation
Collaborator
|
Thanks for this — you correctly identified that the TUI This landed on main via PR #93784 (the composite-carrier retry/undo salvage, merged today): Closing as implemented on main. Appreciate the report and the tests — sorry the broader carrier rework got there first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
session.undoRPC persist rewinds throughSessionDB.rewind_to_messageWhy
The TUI undo path could report that messages were undone while only trimming the in-memory session history. After exiting and resuming the session, the supposedly undone turn reappeared because the rows were still active in
state.db.Tests
HERMES_PYTHON=/usr/bin/python3 scripts/run_tests.sh tests/tui_gateway/test_undo_command.pygit diff --check