fix(cli): hermes -z no longer silently drops -s/--skills (salvage #31591) - #90389
Merged
Conversation
Contributor
૮ >ﻌ< ა ci reviewran on 74c3f05 — test: pin -z/--oneshot --skills forwarding and partial-succe
|
alt-glitch
added
type/bug
This was referenced Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hermes -z -s <skill>now actually preloads the requested skill; before, oneshot mode silently discarded-s/--skillswhilehermes chat -q -shonored it.Salvage of #31591 by @GarlicGo (earliest of 5 independent fixes), cherry-picked onto current main with authorship preserved. Fixes #31548, #65119.
Root cause: the
-zfast path builds itsAIAgentdirectly inhermes_cli/oneshot.py, and neither_run_and_exit_oneshot()norrun_oneshot()accepted or forwarded the skills argument. The skill preload only lived in the interactivecmd_chatpath.Changes
hermes_cli/oneshot.py:_normalize_skills()+_build_preloaded_skills_prompt()(same partial-success contract as CLI chat: skip unknown skills when at least one loads, hard-fail when all are unknown); injected viaephemeral_system_prompthermes_cli/main.py: forwardskills=through all three_run_and_exit_oneshot()call sites — including the top-level fast path added on main after the PR (sibling-site widening)tests/hermes_cli/test_oneshot_skills.py: forwarding + partial-success contract testsValidation
hermes -s github-pr-workflow -z "quote skill heading"NONE(skill absent)# GitHub Pull Request Workflow(live E2E)test_oneshot_skills.py+test_tui_resume_flow.py)Duplicate cluster to close on merge: #31591 (salvaged, credit), #63814, #65249, #75930, #86173.
Infographic