You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
AI code review — automated review for reference, author can ignore or act on any point.
fix(cli): preload skills in oneshot mode
The plumbing through _run_and_exit_oneshot and the _apply_preloaded_skills helper are straightforward, and the tests cover the forwarding and unknown-skill paths. Observations:
hermes_cli/oneshot.py::_apply_preloaded_skills: agent.preloaded_skills is only set when skills_prompt is truthy. If build_preloaded_skills_prompt ever returns a non-empty loaded_skills list with an empty prompt, the agent records no loaded skills even though the load happened. Keying the bookkeeping off loaded_skills (and only the prompt append off skills_prompt) would keep the two consistent.
The behavior split — warn-and-continue when some skills are unknown, raise ValueError when all are unknown — is reasonable, but it means a typo in a single-skill one-shot invocation fails hard while the same typo next to a valid skill is silently forgiven. For a scripted/one-shot context, a consistent warn-and-continue (matching cli.py's tolerance) may be less surprising.
_normalize_toolsets is reused to parse the skills value. If it applies toolset-specific normalization or validation, unknown-skill input may surface toolset-flavored messages before reaching the clearer build_preloaded_skills_prompt messaging — worth verifying the two vocabularies don't collide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comp/cliCLI entry point, hermes_cli/, setup wizardP2Medium — degraded but workaround existstool/skillsSkills system (list, view, manage)type/bugSomething isn't working
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-s/--skillsthrough every one-shot CLI dispatch pathScope
Verification
pytest -q -p no:cacheprovider tests/hermes_cli/test_oneshot_skills.py tests/hermes_cli/test_tui_resume_flow.py tests/hermes_cli/test_argparse_flag_propagation.py tests/cli/test_cli_preloaded_skills.py— 19 passedruff check --no-cache hermes_cli/main.py hermes_cli/oneshot.py tests/hermes_cli/test_oneshot_skills.py— passedtheclamai-content-intelligence, injected 7,721 prompt characters, no network or model call