docs(tools): clarify terminal background waits - #89941
Open
teknium1 wants to merge 1 commit into
Open
Conversation
Port from Kilo-Org/kilocode#13224: fixed waits belong in foreground terminal calls, while background mode is reserved for independently running processes.
Contributor
૮ >ﻌ< ა ci reviewran on a23296c — docs(tools): clarify terminal background waits ❌ Job failuresPython tests / Run tests slice 12/12 · View jobJob Python tests / Run tests slice 12/12 failed. Python tests / e2e · View jobJob Python tests / e2e failed.
|
alt-glitch
added
type/docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Terminal tool instructions now clearly route fixed waits to foreground commands and reserve background mode for independently running processes.
Source
Ported from Kilo-Org/kilocode#13224: Kilo-Org/kilocode#13224
Changes
tools/terminal_tool.py: clarify thatbackground=trueis only for processes that continue independently, and thatsleep/timers/cooldowns should run as normal foreground commands with sufficient timeout.tests/tools/test_terminal_tool.py: lock the schema wording so the guidance stays visible in the tool description.docs/pr-infographics/kilocode-background-wait-guidance.svg: attach the required PR infographic locally because FAL image generation returned exhausted balance.Validation
python3 -m py_compile tools/terminal_tool.py tests/tools/test_terminal_tool.pyscripts/run_tests.sh tests/tools/test_terminal_tool.pyget_tool_definitions(enabled_toolsets=['terminal'])docs/pr-infographics/kilocode-background-wait-guidance.svgInfographic