fix(cli): clarify background process waits - #13224
Merged
Merged
Conversation
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (2 files)
Reviewed by grok-4.6 · Input: 41.3K · Output: 4.1K · Cached: 237.6K Review guidance: REVIEW.md from base branch |
marius-kilocode
enabled auto-merge
August 19, 2026 09:31
chrarnoldus
approved these changes
Aug 19, 2026
teknium1
added a commit
to NousResearch/hermes-agent
that referenced
this pull request
Aug 19, 2026
Port from Kilo-Org/kilocode#13224: fixed waits belong in foreground terminal calls, while background mode is reserved for independently running processes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The background process tool description did not clearly distinguish a persistent process from a blocking wait. This caused agents to launch
sleepas a tracked background process, which returned immediately and led to repeated status checks instead of blocking the turn.Clarify that
startreturns immediately and reserve the tool for processes that must continue independently. Explicitly direct fixed waits to a normal blocking shell command with a sufficient timeout.