fix(update): don't report success when the Desktop rebuild failed (supersedes #88359, #87984) - #89838
Merged
Merged
Conversation
hermes update treated a failed desktop pack as non-fatal and still printed ✓ Update complete!, so Windows users kept running an old Hermes.exe after a "successful" update. Withhold the success banner, surface the stale app in the summary, and write .update_exit_code=1 for gateway watchers. Supersedes #88359, #87984. Co-authored-by: joaomarcos <joaomarcosdias444@gmail.com> Co-authored-by: liuhao1024 <sunsky.lau@gmail.com>
This was referenced Aug 19, 2026
OutThisLife
enabled auto-merge
August 19, 2026 07:40
Collaborator
Author
|
Kicking CI: the |
auto-merge was automatically disabled
August 19, 2026 07:40
Pull request was closed
OutThisLife
enabled auto-merge
August 19, 2026 07:40
OutThisLife
force-pushed
the
bb/update-desktop-rebuild-status
branch
from
August 19, 2026 07:42
d8a4bbb to
ff3dbed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Supersedes #88359 and #87984.
hermes updatetreated a failed Desktop pack as non-fatal: it printed an early warning, then still ended with✓ Update complete!. Python moved on;Hermes.exestayed on the previous build. That is the summary half of #88251 (the get-windows binding recovery is #88233)._rebuild_desktop_after_updatenow returnsFalseonly when a rebuild was attempted and failed. Both the git and ZIP paths then print⚠ Update partially completeinstead of the success banner, and gateway mode writes1to.update_exit_codeso/updatewatchers do not claim success.The success-path output is unchanged when the Desktop rebuild succeeds or is not needed.
Credit: @JoaoMarcos44 (exit status / withhold the banner) and @liuhao1024 (return-value contract and tests).
Related Issue
Related to #88251. Supersedes #88359, #87984.
Type of Change
Changes Made
hermes_cli/update_cmd.py:_rebuild_desktop_after_update()returnsbool; shared_print_update_summary()and_write_gateway_update_exit_code().✓ Update complete!when the rebuild failed..update_exit_code=1in that case.tests/hermes_cli/test_update_desktop_stale_warning.py: rebuild contract, banner, combined node+desktop failure, exit-code file.How to Test
scripts/run_tests.sh tests/hermes_cli/test_update_desktop_stale_warning.py tests/hermes_cli/test_cmd_update.py tests/hermes_cli/test_update_version_report.py -q— 8 new tests plus existing update coverage.hermes update— the run should end with⚠ Update partially completeand a retry hint, not✓ Update complete!.Checklist
Code
fix(scope):,feat(scope):, etc.)Documentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/A