fix(desktop): recover missing get-windows binding - #88233
Merged
OutThisLife merged 3 commits intoAug 19, 2026
Conversation
helix4u
marked this pull request as ready for review
August 17, 2026 07:37
1 task
9 tasks
1 task
OutThisLife
requested changes
Aug 19, 2026
OutThisLife
left a comment
Collaborator
There was a problem hiding this comment.
Almost there — one ask before merge:
The new test get-windows native install invokes node-pre-gyp directly from the package root deepEquals the installer path against join(tmp, ...). On macOS require.resolve returns the realpath (/private/var/...) while tmp is /var/..., so the assertion fails even though the spawn is correct.
Compare against fs.realpathSync(installer) (or resolve both sides the same way). Happy to approve as soon as that's in.
This was referenced Aug 19, 2026
Closed
require.resolve returns the macOS realpath (/private/var/...) while os.tmpdir() stays on the /var symlink, so a raw join() deepEqual failed even though the spawn was correct.
OutThisLife
approved these changes
Aug 19, 2026
OutThisLife
left a comment
Collaborator
There was a problem hiding this comment.
LGTM — the direct installer is the right recovery. I pushed the realpath compare so the macOS test matches require.resolve.
OutThisLife
enabled auto-merge
August 19, 2026 07:40
This was referenced Aug 20, 2026
Open
[Architecture] Treat built artifacts and real protocol peers as part of the system under test
#90150
Open
andrexibiza
added a commit
to andrexibiza/hermes-agent
that referenced
this pull request
Aug 21, 2026
…ling (NousResearch#91079) Rebuild the final eleven-file package transaction as one commit on exact upstream main 67af79d. The final source/test blobs are byte-identical to the reviewed fork head; the five-commit series and all of its historical status objects are removed from active ancestry. Preserves the implementation lineage documented in NousResearch#91079: NousResearch#88233, NousResearch#44234, NousResearch#69179, NousResearch#91063, NousResearch#76088, NousResearch#38170, and NousResearch#34327.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Repairs Desktop packaging when
get-windows@9.3.0is installed without its Windows native binding.The staging script previously ran
npm rebuild get-windows. Becauseget-windowsis optional, npm can report that rebuild as successful even when the package's native lifecycle fails and nonapi-9-win32-unknown-x64payload is produced. The resulting error then recommended the same ineffective command.The staging path now resolves the package's own
@mapbox/node-pre-gypinstaller and runsinstall --fallback-to-builddirectly insideget-windows. It fails on a process error or non-zero exit, rescanslib/binding, and also fails accurately if the installer exits successfully without producing the requested Windows binding.Related Issue
Closes #88251.
Type of Change
Changes Made
@mapbox/node-pre-gypfrom the installedget-windowspackage.How to Test
From
apps/desktop:npm exec -- vitest run scripts/stage-native-deps.test.mjs --testNamePattern "win32 staging|native install"The focused Windows staging tests pass:
6 passed | 24 skipped.A disposable Windows verification also started with no
lib/binding, downloaded the officialv9.3.0/napi-9-win32-unknown-x64.tar.gzasset through the direct installer, producednode-get-windows.node, and classified it as a Windows binary.The full test file reaches
28 passed | 1 skipped; its existing Darwin executable-mode assertion fails on Windows with438 !== 493.Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AScreenshots / Logs
Missing-binding Windows verification:
before: falsenode-pre-gyp ... napi-9-win32-unknown-x64.tar.gzafter: true, classification: win32