Skip to content

fix(codex): drop unsupported pro defaults - #89194

Merged
teknium1 merged 3 commits into
NousResearch:mainfrom
vadelma-agent:fix/codex-drop-unsupported-pro-defaults-20260818
Aug 18, 2026
Merged

fix(codex): drop unsupported pro defaults#89194
teknium1 merged 3 commits into
NousResearch:mainfrom
vadelma-agent:fix/codex-drop-unsupported-pro-defaults-20260818

Conversation

@vadelma-agent

@vadelma-agent vadelma-agent commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Bug

When live ChatGPT Codex OAuth discovery is unavailable, Hermes falls back to curated and forward-compatible model choices. That fallback offered gpt-5.6-sol-pro, gpt-5.6-terra-pro, and gpt-5.6-luna-pro, but the ChatGPT Codex OAuth backend rejects those slugs with HTTP 400. This left users with dead /model choices during offline/failed discovery.

Fix

  • Remove only those three rejected -pro slugs from the curated Codex OAuth fallback and forward-compat templates.
  • Retain gpt-5.6-sol, gpt-5.6-terra, and gpt-5.6-luna.
  • Assert both source-list and get_codex_model_ids() output behavior.

Scope

This intentionally does not alter broader public OpenAI, OpenRouter, or website catalog entries. It is a current-main, actively maintained superseding implementation of the still-open but conflicting/stale #61665, while preserving that PR’s narrow two-file intent and acknowledging its original contributor. It is not an unrelated duplicate: #89194 provides the maintained branch, current-base integration, and review/test evidence needed to land the same bounded fix.

How to Test

Current exact-head verification

Published head: e156bbbe603e6ff6bcfc2c99417e9d43898fdaa6
Rebased base: 8911e2e0edf750b104edbdc106d63d6cdac88524

The repository's canonical isolated test wrapper was run from a clean checkout of that exact head:

scripts/run_tests.sh -q tests/hermes_cli/test_codex_models.py
7 passed, 0 failed

git diff --check 8911e2e0edf750b104edbdc106d63d6cdac88524 e156bbbe603e6ff6bcfc2c99417e9d43898fdaa6
passed

This covers Codex OAuth curated fallback and forward-compat model selection. The candidate checkout remained clean after the run. The full repository suite was not run and is not claimed as passing.

@alt-glitch alt-glitch added type/bug Something isn't working comp/cli CLI entry point, hermes_cli/, setup wizard provider/openai OpenAI / Codex Responses API P3 Low — cosmetic, nice to have duplicate This issue or pull request already exists labels Aug 18, 2026
@alt-glitch

Copy link
Copy Markdown
Collaborator

This was generated by AI during triage.

Duplicate of #61665. The diffs make the same curated and forward-compat catalog removal for the same three unsupported Codex OAuth model slugs.

@vadelma-agent
vadelma-agent force-pushed the fix/codex-drop-unsupported-pro-defaults-20260818 branch 2 times, most recently from aad206f to 79466ab Compare August 18, 2026 14:08
vadelma-agent and others added 2 commits August 18, 2026 17:17
Port the stale PR NousResearch#61665 behavior to current main. The original two-file contribution is by yungchentang; this candidate preserves its scoped Codex OAuth fallback intent.

Co-authored-by: Taneli Mielikäinen <taneli.mielikainen@iki.fi>
Co-authored-by: Taneli Mielikäinen <taneli.mielikainen@iki.fi>
@vadelma-agent
vadelma-agent force-pushed the fix/codex-drop-unsupported-pro-defaults-20260818 branch from 79466ab to e156bbb Compare August 18, 2026 14:17
teknium1 added a commit that referenced this pull request Aug 18, 2026
Maps vadelma@agenttiklubi.org and the bare noreply address to
vadelma-agent, and taneli.mielikainen@iki.fi to tmielika, so the
check-attribution gate passes on their open PRs (#70667, #72671,
#67934, #86255, #89194).
@teknium1
teknium1 merged commit 7d780cc into NousResearch:main Aug 18, 2026
45 checks passed
lisajlau pushed a commit to lisajlau/hermes-agent that referenced this pull request Aug 20, 2026
Maps vadelma@agenttiklubi.org and the bare noreply address to
vadelma-agent, and taneli.mielikainen@iki.fi to tmielika, so the
check-attribution gate passes on their open PRs (NousResearch#70667, NousResearch#72671,
NousResearch#67934, NousResearch#86255, NousResearch#89194).
prmartinow pushed a commit to prmartinow/hermes-agent that referenced this pull request Aug 26, 2026
Maps vadelma@agenttiklubi.org and the bare noreply address to
vadelma-agent, and taneli.mielikainen@iki.fi to tmielika, so the
check-attribution gate passes on their open PRs (NousResearch#70667, NousResearch#72671,
NousResearch#67934, NousResearch#86255, NousResearch#89194).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/cli CLI entry point, hermes_cli/, setup wizard duplicate This issue or pull request already exists P3 Low — cosmetic, nice to have provider/openai OpenAI / Codex Responses API type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants