fix(codex): drop unsupported pro defaults - #89194
Merged
teknium1 merged 3 commits intoAug 18, 2026
Merged
Conversation
Collaborator
Duplicate of #61665. The diffs make the same curated and forward-compat catalog removal for the same three unsupported Codex OAuth model slugs. |
vadelma-agent
force-pushed
the
fix/codex-drop-unsupported-pro-defaults-20260818
branch
2 times, most recently
from
August 18, 2026 14:08
aad206f to
79466ab
Compare
Port the stale PR NousResearch#61665 behavior to current main. The original two-file contribution is by yungchentang; this candidate preserves its scoped Codex OAuth fallback intent. Co-authored-by: Taneli Mielikäinen <taneli.mielikainen@iki.fi>
Co-authored-by: Taneli Mielikäinen <taneli.mielikainen@iki.fi>
vadelma-agent
force-pushed
the
fix/codex-drop-unsupported-pro-defaults-20260818
branch
from
August 18, 2026 14:17
79466ab to
e156bbb
Compare
teknium1
added a commit
that referenced
this pull request
Aug 18, 2026
lisajlau
pushed a commit
to lisajlau/hermes-agent
that referenced
this pull request
Aug 20, 2026
Maps vadelma@agenttiklubi.org and the bare noreply address to vadelma-agent, and taneli.mielikainen@iki.fi to tmielika, so the check-attribution gate passes on their open PRs (NousResearch#70667, NousResearch#72671, NousResearch#67934, NousResearch#86255, NousResearch#89194).
prmartinow
pushed a commit
to prmartinow/hermes-agent
that referenced
this pull request
Aug 26, 2026
Maps vadelma@agenttiklubi.org and the bare noreply address to vadelma-agent, and taneli.mielikainen@iki.fi to tmielika, so the check-attribution gate passes on their open PRs (NousResearch#70667, NousResearch#72671, NousResearch#67934, NousResearch#86255, NousResearch#89194).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
When live ChatGPT Codex OAuth discovery is unavailable, Hermes falls back to curated and forward-compatible model choices. That fallback offered
gpt-5.6-sol-pro,gpt-5.6-terra-pro, andgpt-5.6-luna-pro, but the ChatGPT Codex OAuth backend rejects those slugs with HTTP 400. This left users with dead/modelchoices during offline/failed discovery.Fix
-proslugs from the curated Codex OAuth fallback and forward-compat templates.gpt-5.6-sol,gpt-5.6-terra, andgpt-5.6-luna.get_codex_model_ids()output behavior.Scope
This intentionally does not alter broader public OpenAI, OpenRouter, or website catalog entries. It is a current-main, actively maintained superseding implementation of the still-open but conflicting/stale #61665, while preserving that PR’s narrow two-file intent and acknowledging its original contributor. It is not an unrelated duplicate: #89194 provides the maintained branch, current-base integration, and review/test evidence needed to land the same bounded fix.
How to Test
Current exact-head verification
Published head:
e156bbbe603e6ff6bcfc2c99417e9d43898fdaa6Rebased base:
8911e2e0edf750b104edbdc106d63d6cdac88524The repository's canonical isolated test wrapper was run from a clean checkout of that exact head:
This covers Codex OAuth curated fallback and forward-compat model selection. The candidate checkout remained clean after the run. The full repository suite was not run and is not claimed as passing.