fix(codex): drop unsupported pro defaults - #61665
Conversation
|
Thanks for the focused Codex fallback correction. Current No correctness or scope issues found in the two-file diff. This is an automated hermes-sweeper review. |
|
Independent verification on the released v0.19.0 confirms this PR is still needed. Environment
Live authenticated evidenceThe raw Current unpatched Hermes expands that live list to: The three Fresh CLI differential repro: hermes chat -q 'Reply with exactly: PRO_OK' \
-m gpt-5.6-sol-pro --provider openai-codex -t safe -QResult: Control request with the same account/provider: hermes chat -q 'Reply with exactly: BASE_OK' \
-m gpt-5.6-sol --provider openai-codex -t safe -QResult: PR verification against the released 0.19 treeI applied commit scripts/run_tests.sh tests/hermes_cli/test_codex_models.py -qResult: I also exercised the patched resolver against the live GPT-5.6 base slug set. Before the patch it synthesizes all three No This bug is user-visible in the v0.19.0 release: the picker advertises a model that the selected provider deterministically rejects. The patch is focused, applies cleanly to the release tree, and has fresh local verification. Please consider merging #61665. |
Port the stale PR NousResearch#61665 behavior to current main. The original two-file contribution is by yungchentang; this candidate preserves its scoped Codex OAuth fallback intent. Co-authored-by: Taneli Mielikäinen <taneli.mielikainen@iki.fi>
Port the stale PR #61665 behavior to current main. The original two-file contribution is by yungchentang; this candidate preserves its scoped Codex OAuth fallback intent. Co-authored-by: Taneli Mielikäinen <taneli.mielikainen@iki.fi>
|
Fixed by PR #89194 (merged, commit 7d780cc) — same fix, maintained against current main. You were the first to submit this fix (July 9), and your diagnosis of the ChatGPT Codex OAuth backend rejecting the synthetic -pro fallbacks was correct — thank you. Your branch had gone stale against main, so the maintained successor landed instead. First-submitter credit to you; the PR body of #89194 and this comment record it. |
Port the stale PR NousResearch#61665 behavior to current main. The original two-file contribution is by yungchentang; this candidate preserves its scoped Codex OAuth fallback intent. Co-authored-by: Taneli Mielikäinen <taneli.mielikainen@iki.fi>
Summary
gpt-5.6-sol-pro,gpt-5.6-terra-pro, andgpt-5.6-luna-proslugs from the curated Codex OAuth fallback list.-proslugs while keeping the non-pro GPT-5.6 Sol/Terra/Luna entries available.Root Cause
-proGPT-5.6 slugs to the Codex OAuth curated fallback/template list.Live Evidence
chatgpt.com/backend-api/codex/responsesOAuth Codex route on a ChatGPT Pro account on 2026-07-10.gpt-5.5,gpt-5.4,gpt-5.3-codex-spark,gpt-5.6-sol, andgpt-5.6-terra.gpt-5.6-sol-pro,gpt-5.6-terra-pro, andgpt-5.6-luna-pro.Tests
scripts/run_tests.sh tests/hermes_cli/test_codex_models.py -qpython3 -m py_compile hermes_cli/codex_models.py tests/hermes_cli/test_codex_models.pygit diff --checkFixes #61660