fix(desktop): FindBar no longer overlaps native window controls - #86746
Merged
Merged
Conversation
The ⌘F/Ctrl+F find bar positions itself at top-[calc(var(--titlebar-height,0px)+0.5rem)], but it mounts at the overlay root in ContribWiring, outside any subtree that defines --titlebar-height. The 0px fallback parked the bar inside the 34px titlebar strip, underneath the native min/max/close window-controls overlay on Windows/Linux (two X buttons side by side, close button half-covered). Fix: use the real titlebar height (34px) as the fallback, matching the established pattern in floating-hud.ts and notifications.tsx. The bar now floats just below the titlebar band, clear of the window controls.
Contributor
૮ >ﻌ< ა ci reviewran on 75ce05b — fix(desktop): FindBar no longer overlaps native window contr
|
alt-glitch
added
type/bug
Contributor
This was referenced Aug 15, 2026
fix(desktop): count all five static titlebar buttons; find-bar overlay guard (salvage #72959)
#86847
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The desktop Ctrl+F/⌘F find bar now floats below the titlebar instead of rendering inside the titlebar strip underneath the native min/max/close window-controls overlay.
Root cause:
FindBarpositions itself withtop-[calc(var(--titlebar-height,0px)+0.5rem)], but it mounts at the overlay root inContribWiring— outside any subtree that defines--titlebar-height(the contrib shell even zeroes it for content areas). The0pxfallback parked the bar at the very top edge, where Windows/Linux draw the native window controls: two ✕ buttons side by side, with the bar's border clipping into the window close button.Changes
apps/desktop/src/components/find-bar.tsx: fallback0px→34px(the realTITLEBAR_HEIGHT), matching the established pattern infloating-hud.tsandnotifications.tsxwhich face the same unset-var mount point.Validation
find-bar.test.tsxInfographic