Skip to content

fix(desktop): space out find-bar buttons and anchor it below the titlebar - #85181

Closed
tyfcontent wants to merge 1 commit into
NousResearch:mainfrom
tyfcontent:fix/find-bar-spacing
Closed

tyfcontent wants to merge 1 commit into
NousResearch:mainfrom
tyfcontent:fix/find-bar-spacing

Conversation

@tyfcontent

Copy link
Copy Markdown
Contributor

What

Two related fixes to the find-in-page bar (Ctrl+F / ⌘F):

  1. Anchor the bar below the titlebar. The top-[...] calc used a 0px fallback for --titlebar-height, but that variable is unset at the find bar's mount point (the contrib shell zeroes it and hardcodes the titlebar to h-[34px]), so the bar rendered at ~8px — inside the titlebar, over the window controls. Use the same 34px fallback as the sibling overlays (notifications.tsx, floating-hud.ts).

  2. Space out and enlarge the controls. Buttons go from h-5 w-5 (20px) to h-7 w-7 (28px) with matching icon glyph bumps, and the container gap goes from gap-1 to gap-2 (plus py-1.5), so the previous/next/close buttons are no longer crammed together and mis-clicked.

Test plan

  • npx vitest run src/components/find-bar.test.tsx — 48/48 passing
  • npx eslint src/components/find-bar.tsx — clean
  • Manual: open the app, press Ctrl+F, type a query — bar sits below the titlebar with comfortable button spacing; Escape / Enter / ⌘G still work.

Changes

apps/desktop/src/components/find-bar.tsx

@alt-glitch alt-glitch added type/bug Something isn't working P3 Low — cosmetic, nice to have comp/desktop Electron desktop app (apps/desktop/*) platform/windows Native Windows-specific behavior or breakage labels Aug 13, 2026
@teknium1

Copy link
Copy Markdown
Collaborator

Salvaged into #86840 (merged) — your spacing/hit-target polish landed with your authorship preserved via cherry-pick. The positioning half (34px fallback) was dropped only because it had already landed via #86746/#80244. Thanks @tyfcontent!

@teknium1 teknium1 closed this Aug 15, 2026
bobaba76 pushed a commit to bobaba76/hermes-agent that referenced this pull request Aug 27, 2026
melon-xf added a commit to melon-xf/hermes-agent that referenced this pull request Sep 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/desktop Electron desktop app (apps/desktop/*) P3 Low — cosmetic, nice to have platform/windows Native Windows-specific behavior or breakage type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants