fix(desktop): space out find-bar buttons and anchor it below the titlebar - #85181
Closed
tyfcontent wants to merge 1 commit into
Closed
tyfcontent wants to merge 1 commit into
tyfcontent wants to merge 1 commit into
Conversation
teknium1
added a commit
that referenced
this pull request
Aug 15, 2026
Collaborator
|
Salvaged into #86840 (merged) — your spacing/hit-target polish landed with your authorship preserved via cherry-pick. The positioning half (34px fallback) was dropped only because it had already landed via #86746/#80244. Thanks @tyfcontent! |
bobaba76
pushed a commit
to bobaba76/hermes-agent
that referenced
this pull request
Aug 27, 2026
melon-xf
added a commit
to melon-xf/hermes-agent
that referenced
this pull request
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two related fixes to the find-in-page bar (
Ctrl+F/⌘F):Anchor the bar below the titlebar. The
top-[...]calc used a0pxfallback for--titlebar-height, but that variable is unset at the find bar's mount point (the contrib shell zeroes it and hardcodes the titlebar toh-[34px]), so the bar rendered at ~8px — inside the titlebar, over the window controls. Use the same34pxfallback as the sibling overlays (notifications.tsx,floating-hud.ts).Space out and enlarge the controls. Buttons go from
h-5 w-5(20px) toh-7 w-7(28px) with matching icon glyph bumps, and the container gap goes fromgap-1togap-2(pluspy-1.5), so the previous/next/close buttons are no longer crammed together and mis-clicked.Test plan
npx vitest run src/components/find-bar.test.tsx— 48/48 passingnpx eslint src/components/find-bar.tsx— cleanChanges
apps/desktop/src/components/find-bar.tsx