Skip to content

fix(tests): resolve cost-guard fixture collision breaking main slice 6 #85970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
teknium1 merged 1 commit into from
Aug 14, 2026
Merged

fix(tests): resolve cost-guard fixture collision breaking main slice 6 #85970

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 21 additions & 4 deletions tests/hermes_cli/test_model_cost_guard.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,13 @@ def test_warns_when_models_dev_input_price_exceeds_threshold():

@pytest.mark.parametrize("provider", ["custom", "custom:routerai", "routerai"])
def test_skips_foreign_models_dev_pricing_for_custom_or_unknown_providers(provider):
# NOTE: deliberately NOT openai/gpt-5.5-pro — that id carries an
# unconditional known-confusion warning (GPT55_PRO_OPENROUTER_ID) that is
# id-keyed and independent of pricing trust, so it would mask what this
# test asserts (foreign models.dev pricing being distrusted).
info = ModelInfo(
id="openai/gpt-5.5-pro",
name="openai/gpt-5.5-pro",
id="vendor/priced-model",
name="vendor/priced-model",
family="",
provider_id="openrouter",
cost_input=25.0,
Expand All @@ -55,7 +59,7 @@ def test_skips_foreign_models_dev_pricing_for_custom_or_unknown_providers(provid

assert (
expensive_model_warning(
"openai/gpt-5.5-pro",
"vendor/priced-model",
provider=provider,
model_info=info,
)
Expand All @@ -78,7 +82,7 @@ def fake_get_pricing_entry(*_args, **_kwargs):
monkeypatch.setattr("agent.usage_pricing.get_pricing_entry", fake_get_pricing_entry)

warning = expensive_model_warning(
"openai/gpt-5.5-pro",
"vendor/priced-model",
provider="custom:routerai",
base_url="https://routerai.example/v1",
)
Expand All @@ -87,6 +91,19 @@ def fake_get_pricing_entry(*_args, **_kwargs):
assert pricing_calls == []


def test_known_confusing_model_still_warns_on_custom_provider():
"""The gpt-5.5-pro confusion nudge is id-keyed, not pricing-keyed: it must
survive the custom-provider pricing distrust (54cc39aa15 x 83d373aae6)."""
warning = expensive_model_warning(
"openai/gpt-5.5-pro",
provider="custom:routerai",
base_url="https://routerai.example/v1",
)

assert warning is not None
assert "did you mean to select openai/gpt-5.5?" in warning.message


def test_warns_when_pricing_entry_output_price_exceeds_threshold(monkeypatch):
monkeypatch.setattr("agent.models_dev.get_model_info", lambda *_args, **_kwargs: None)
monkeypatch.setattr(
Expand Down
Loading