fix(tests): resolve cost-guard fixture collision breaking main slice 6 - #85970
Merged
Conversation
…rust and gpt-5.5-pro confusion nudge 54cc39a (distrust foreign pricing for custom providers) tested with openai/gpt-5.5-pro fixtures; 83d373a (salvaged #70324) made that exact id warn unconditionally as a known-confusion model. Each was green alone; together the distrust tests fail on every main run (slice 6). Use a neutral fixture id for the distrust tests and add a regression test pinning the composed behavior: the id-keyed nudge survives custom-provider pricing distrust.
Contributor
૮ >ﻌ< ა ci reviewran on a055d51 — fix(tests): resolve cost-guard fixture collision between pri
|
alt-glitch
added
type/test
This was referenced Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Main's slice 6 is red from a semantic collision between two commits that were each green in isolation: 54cc39a (custom-provider pricing distrust, tested with
openai/gpt-5.5-profixtures) and 83d373a (salvaged #70324, which makesopenai/gpt-5.5-prowarn UNCONDITIONALLY as a known-confusion id, regardless of pricing trust). The distrust tests now get the id-keyed nudge warning where they assertNone— 4 failures on every main run and every PR since 3c5fd91.Not a flake and not a regression in either fix's logic: the two behaviors are both correct, the test fixtures just collided on that one model id.
Changes
tests/hermes_cli/test_model_cost_guard.py: pricing-distrust tests use a neutralvendor/priced-modelfixture id so they assert what they actually test (foreign pricing distrust), with a comment explaining why gpt-5.5-pro can't be the fixturetest_known_confusing_model_still_warns_on_custom_provider: pins the intended composed behavior — the id-keyed confusion nudge survives custom-provider pricing distrustValidation
tests/hermes_cli/test_model_cost_guard.pytest_cli_startup_model_cost_guard.pyInfographic