Conversation
Adolanium
added a commit
to Adolanium/hermes-agent
that referenced
this pull request
Aug 13, 2026
Failed --action specs IndexError and skip context.close(), so the HAR never lands. CDP attach drives pages[0] (and --goto navigates it), and derivation drops form params and base64 response bodies. Share a validated run_action helper (bad specs fail with a clear ValueError, including empty selectors), flush the Playwright HAR in finally, listen on every CDP context, and open a new tab for --goto so it cannot wipe the tab Hermes is driving. In-flight requests left after --wait are flushed as entries with a null response, after detaching the listeners. Calling the waiting request.response() there could hang the capture (no timeout) or record a late response twice. har_to_client now reads params-only postData and decodes base64 content. Does not change header redaction, scheme printing, or CDP queryString (NousResearch#85053). Null postData is handled by the new body helper, which supersedes NousResearch#84977.
Author
Overlap with #85085The two PRs address different bug classes, but they overlap substantially at the file level.
Both PRs modify:
A three-way merge of the exact commits produces content conflicts in Conclusion: different bugs, overlapping implementation areas, not duplicate PRs. |
Adolanium
added a commit
to Adolanium/hermes-agent
that referenced
this pull request
Oct 1, 2026
Failed --action specs IndexError and skip context.close(), so the HAR never lands. CDP attach drives pages[0] (and --goto navigates it), and derivation drops form params and base64 response bodies. Share a validated run_action helper (bad specs fail with a clear ValueError, including empty selectors), flush the Playwright HAR in finally, listen on every CDP context, and open a new tab for --goto so it cannot wipe the tab Hermes is driving. In-flight requests left after --wait are flushed as entries with a null response, after detaching the listeners. Calling the waiting request.response() there could hang the capture (no timeout) or record a late response twice. har_to_client now reads params-only postData and decodes base64 content. Does not change header redaction, scheme printing, or CDP queryString (NousResearch#85053). Null postData is handled by the new body helper, which supersedes NousResearch#84977.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix three reproducible correctness and secret-handling problems in the optional
har-derived-api-clientskill:har_to_client.pyoutput;https://;queryStringentries, including repeated and blank parameters.The skill documentation now tells users to obtain current credentials from an approved runtime secret source rather than copying values from a HAR into code or shell history.
Reproduction on current
mainA synthetic HTTP HAR with
AuthorizationandX-API-Keyheaders currently:Separately,
_har_entry()inhar_capture_cdp.pycurrently emits an emptyqueryStringarray even when the request URL contains query parameters.Changes
[REDACTED]instead of their values;url.schemein endpoint grouping and output;queryString;queryStringfrom the request URL while preserving repeated and blank values;SKILL.md.Verification
Tested on Linux with Python 3.12. No live credentials or network calls were used.
Scope note
This intentionally does not include the
postData: nullfix from #84977, so the two pull requests do not overlap.