fix(har-derived-api-client): handle postData: null in HAR entries - #84977
Open
thaingo72-ctrl wants to merge 1 commit into
Open
thaingo72-ctrl wants to merge 1 commit into
thaingo72-ctrl wants to merge 1 commit into
Conversation
req.get("postData", {}) returns None when a HAR entry explicitly has
postData: null (common for GET-only requests), crashing har_to_client.py
with AttributeError: 'NoneType' object has no attribute 'get'. Use
req.get("postData") or {} so null and absent both become an empty dict.
alt-glitch
added
type/bug
Adolanium
added a commit
to Adolanium/hermes-agent
that referenced
this pull request
Aug 13, 2026
Failed --action specs IndexError and skip context.close(), so the HAR never lands. CDP attach drives pages[0] (and --goto navigates it), and derivation drops form params and base64 response bodies. Share a validated run_action helper (bad specs fail with a clear ValueError, including empty selectors), flush the Playwright HAR in finally, listen on every CDP context, and open a new tab for --goto so it cannot wipe the tab Hermes is driving. In-flight requests left after --wait are flushed as entries with a null response, after detaching the listeners. Calling the waiting request.response() there could hang the capture (no timeout) or record a late response twice. har_to_client now reads params-only postData and decodes base64 content. Does not change header redaction, scheme printing, or CDP queryString (NousResearch#85053). Null postData is handled by the new body helper, which supersedes NousResearch#84977.
fix(har-derived-api-client): handle postData: null in HAR entries
|
Adolanium
added a commit
to Adolanium/hermes-agent
that referenced
this pull request
Oct 1, 2026
Failed --action specs IndexError and skip context.close(), so the HAR never lands. CDP attach drives pages[0] (and --goto navigates it), and derivation drops form params and base64 response bodies. Share a validated run_action helper (bad specs fail with a clear ValueError, including empty selectors), flush the Playwright HAR in finally, listen on every CDP context, and open a new tab for --goto so it cannot wipe the tab Hermes is driving. In-flight requests left after --wait are flushed as entries with a null response, after detaching the listeners. Calling the waiting request.response() there could hang the capture (no timeout) or record a late response twice. har_to_client now reads params-only postData and decodes base64 content. Does not change header redaction, scheme printing, or CDP queryString (NousResearch#85053). Null postData is handled by the new body helper, which supersedes NousResearch#84977.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
har_to_client.pycrashes withAttributeError: 'NoneType' object has no attribute 'get'when a HAR entry contains"postData": null— which is common for GET-only requests (Chrome/Playwright HARs include the key explicitly with a null value).req.get("postData", {})only defaults when the key is absent, not when it's explicitly null.Fix
req.get("postData") or {}— null and absent both become an empty dict.Verification
postData: null→ crash at line 91