Skip to content

fix(time): read timezone from config.yaml as UTF-8 - #8455

Closed
Tianworld wants to merge 1 commit into
NousResearch:mainfrom
Tianworld:fix/hermes-timezone-config-utf8
Closed

fix(time): read timezone from config.yaml as UTF-8#8455
Tianworld wants to merge 1 commit into
NousResearch:mainfrom
Tianworld:fix/hermes-timezone-config-utf8

Conversation

@Tianworld

Copy link
Copy Markdown
Contributor

hermes_time falls back to config.yaml for HERMES_TIMEZONE. The file was opened without encoding, so on Windows valid UTF-8 YAML could fail to parse and the configured timezone would be ignored.

Made with Cursor

get_timezone_from_config used locale-default decoding; UTF-8 config.yaml on Windows could be mis-read and timezone silently dropped.

Made-with: Cursor
@alt-glitch alt-glitch added type/bug Something isn't working P3 Low — cosmetic, nice to have area/config Config system, migrations, profiles duplicate This issue or pull request already exists labels Apr 28, 2026
@alt-glitch

Copy link
Copy Markdown
Collaborator

Likely duplicate of #15519 — same root cause: missing encoding='utf-8' on open() calls, covered by the broader cross-platform fix.

@teknium1

Copy link
Copy Markdown
Contributor

Thanks for the focused Windows compatibility fix.

Automated hermes-sweeper review found this is already implemented on main:

Closing as already implemented on main.

@teknium1 teknium1 closed this Jul 12, 2026
@teknium1 teknium1 added the sweeper:implemented-on-main Sweeper: behavior already present on current main label Jul 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/config Config system, migrations, profiles duplicate This issue or pull request already exists P3 Low — cosmetic, nice to have sweeper:implemented-on-main Sweeper: behavior already present on current main type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants