fix(time): read timezone from config.yaml as UTF-8 - #8455
Closed
Tianworld wants to merge 1 commit into
Closed
Conversation
get_timezone_from_config used locale-default decoding; UTF-8 config.yaml on Windows could be mis-read and timezone silently dropped. Made-with: Cursor
Collaborator
|
Likely duplicate of #15519 — same root cause: missing encoding='utf-8' on open() calls, covered by the broader cross-platform fix. |
6 tasks
Contributor
|
Thanks for the focused Windows compatibility fix. Automated hermes-sweeper review found this is already implemented on
Closing as already implemented on main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hermes_time falls back to config.yaml for HERMES_TIMEZONE. The file was opened without encoding, so on Windows valid UTF-8 YAML could fail to parse and the configured timezone would be ignored.
Made with Cursor