fix(hermes_time): read config yaml as utf-8 - #17740
Closed
acefun29 wants to merge 1 commit into
Closed
Conversation
Collaborator
Collaborator
|
Likely duplicate of #8455 — same UTF-8 encoding fix for hermes_time.py config read. |
Contributor
|
Closing as already implemented on Evidence from this automated hermes-sweeper review:
Thanks for the focused Windows repro and regression-test contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes timezone config loading when
config.yamlis UTF-8 but the platform default text encoding is different.Previously,
hermes_time.pyopened the user'sconfig.yamlwithout an explicit encoding. On systems where the default encoding is not UTF-8, a config file containing non-ASCII UTF-8 text could fail to decode and silently fall back to the local timezone. This PR reads the config as UTF-8 explicitly, matching how Hermes config files are normally written.Related Issue
N/A
Type of Change
Changes Made
hermes_time.pyto readconfig.yamlwithencoding="utf-8".tests/test_timezone.pythat simulates a non-UTF-8 default encoding while reading a UTF-8 config file.How to Test
Result:
Checklist