Skip to content

fix(doctor): project .env encoding fallback and UTF-8 YAML reads - #8446

Closed
Tianworld wants to merge 1 commit into
NousResearch:mainfrom
Tianworld:fix/doctor-project-env-yaml-utf8
Closed

fix(doctor): project .env encoding fallback and UTF-8 YAML reads#8446
Tianworld wants to merge 1 commit into
NousResearch:mainfrom
Tianworld:fix/doctor-project-env-yaml-utf8

Conversation

@Tianworld

Copy link
Copy Markdown
Contributor

Fixes real Windows/support issues: (1) project .env was UTF-8-only while user .env had latin-1 fallback — cp1252 project files could break doctor at startup; (2) two config.yaml reads used locale default encoding and could mis-parse UTF-8 YAML or skip stale-key migration logic.

Made with Cursor

- Match dump-style latin-1 fallback for repo-root .env on Windows cp1252
- Open config.yaml as UTF-8 for stale-key scan and memory provider detection

Made-with: Cursor
@alt-glitch alt-glitch added type/bug Something isn't working P3 Low — cosmetic, nice to have comp/cli CLI entry point, hermes_cli/, setup wizard area/config Config system, migrations, profiles labels Apr 28, 2026
@alt-glitch

Copy link
Copy Markdown
Collaborator

Likely duplicate of #8432 — same doctor .env encoding + UTF-8 YAML reads fix. Also overlaps #8469.

@teknium1

Copy link
Copy Markdown
Contributor

Closing as already fixed on main.

Triage notes (high confidence):
doctor.py:24 on main uses load_hermes_dotenv (UTF-8+latin-1 fallback for both hermes_home and project .env) and the yaml reads at doctor.py:738 and 1859 already pin encoding='utf-8'.

If you still see this on the latest version, please reopen with reproduction steps.

(Bulk-closed during a CLI triage sweep.)

@teknium1 teknium1 closed this May 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/config Config system, migrations, profiles comp/cli CLI entry point, hermes_cli/, setup wizard P3 Low — cosmetic, nice to have type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants