fix(doctor): use load_dotenv_path and UTF-8 for config reads - #8432
Closed
Tianworld wants to merge 1 commit into
Closed
fix(doctor): use load_dotenv_path and UTF-8 for config reads#8432Tianworld wants to merge 1 commit into
Tianworld wants to merge 1 commit into
Conversation
- Match env_loader .env decoding (UTF-8 + latin-1) for project .env - Open config.yaml as UTF-8 when scanning stale keys and memory provider Made-with: Cursor
This was referenced Apr 28, 2026
alt-glitch
added
type/bug
Collaborator
|
Related to #8415 (same UTF-8 encoding fix pattern for .env loading). Consider merging these into a single PR. |
Contributor
|
Closing as already fixed on Triage notes (high confidence): If you still see this on the latest version, please reopen with reproduction steps. (Bulk-closed during a CLI triage sweep.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
.envviaload_dotenv_path(UTF-8 + latin-1 fallback).config.yamlas UTF-8 in stale-key detection and memory-provider probe.Why
Project
.envpreviously used UTF-8 only; Windows cp1252 files could fail. YAML reads without encoding use locale defaults on Windows.How to test
\\�ash
hermes doctor
\\
Made with Cursor