Skip to content

fix(guard): catch ValueError from os.open on NUL-containing paths (#77780) #77806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
RelaxJonh wants to merge 1 commit into from
Closed

fix(guard): catch ValueError from os.open on NUL-containing paths (#77780) #77806

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion cron/lifecycle_guard.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,10 @@ def _read_referenced_script(path: Path) -> tuple[Optional[str], bool]:
flags = os.O_RDONLY | getattr(os, "O_NONBLOCK", 0)
try:
descriptor = os.open(path, flags)
except OSError:
except (OSError, ValueError):
# OSError: unreadable/long paths. ValueError: embedded NUL byte
# in the path from binary content tokenized as a script path —
# a guarded path must never crash the guard (#76762, #77780).
return None, False
try:
metadata = os.fstat(descriptor)
Expand Down
Loading