fix(guard): catch ValueError from os.open on NUL-containing paths (#77780) - #77806
Closed
RelaxJonh wants to merge 1 commit into
Closed
fix(guard): catch ValueError from os.open on NUL-containing paths (#77780)#77806RelaxJonh wants to merge 1 commit into
RelaxJonh wants to merge 1 commit into
Conversation
…usResearch#77780) os.open() raises ValueError when the path contains an embedded NUL byte, but _read_referenced_script only caught OSError. Add ValueError to the except clause to prevent the guard from crashing.
alt-glitch
added
type/bug
Collaborator
This was referenced Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #77780
_read_referenced_script()incron/lifecycle_guard.pycallsos.open(path, flags)but only catchesOSError. When the path contains an embedded NUL byte (from binary content tokenized as a script path),os.open()raisesValueError: embedded null bytewhich propagates uncaught throughcontains_gateway_lifecycle_command_or_referenced_script→terminal_tool, blocking all subsequent terminal commands.The caller at line 318 already handles
ValueErrorforscript_path.resolve(), but theos.open()call at line 260 was missed.Fix
Add
ValueErrorto theexceptclause atlifecycle_guard.py:261, matching the existing pattern at line 318.