Skip to content

perf(cli): npm --prefer-offline during update (#39399 salvage) #77613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kshitijk4poor merged 1 commit into from
Aug 3, 2026
Merged

perf(cli): npm --prefer-offline during update (#39399 salvage) #77613

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion hermes_cli/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5710,7 +5710,7 @@ def _install_web_deps(*, silent: bool) -> "subprocess.CompletedProcess":
return _run_npm_install_deterministic(
npm,
npm_cwd,
extra_args=(*npm_workspace_args, "--silent") if silent else npm_workspace_args,
extra_args=(*npm_workspace_args, "--silent", "--prefer-offline") if silent else (*npm_workspace_args, "--prefer-offline"),
env=build_env,
)

Expand Down
2 changes: 1 addition & 1 deletion hermes_cli/update_cmd.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2089,7 +2089,7 @@ def _partial_update_failure(*labels: str) -> list[str]:
print(" deps). Fix npm and re-run `hermes update`.")
return list(labels)

extra_args = ["--no-fund", "--no-audit", "--progress=false"]
extra_args = ["--no-fund", "--no-audit", "--prefer-offline", "--progress=false"]

from hermes_constants import with_hermes_node_path

Expand Down
2 changes: 1 addition & 1 deletion tests/hermes_cli/test_web_ui_build.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ def test_web_install_omits_workspace_when_web_has_own_lockfile(
assert result is True
args, kwargs = mock_run.call_args
assert "--workspace" not in args[0]
assert args[0] == ["/usr/bin/npm", "ci", "--include=dev", "--silent"]
assert args[0] == ["/usr/bin/npm", "ci", "--include=dev", "--silent", "--prefer-offline"]
assert kwargs["cwd"] == web_dir

def test_web_build_uses_idle_timeout_helper(self, tmp_path):
Expand Down
Loading