perf(cli): npm --prefer-offline during update (#39399 salvage) - #77613
Merged
kshitijk4poor merged 1 commit intoAug 3, 2026
Merged
Conversation
…earch#39267) Re-derivation of PR NousResearch#39399 onto current main: pass --prefer-offline to the web-UI workspace install (both silent and verbose arms of _install_web_deps) and to the update-time Node dependency refresh in _update_node_dependencies, so npm reuses its local cache instead of re-fetching metadata. Test expectations updated to match, mirroring the PR's own test-update commit.
kshitijk4poor
enabled auto-merge (rebase)
August 3, 2026 11:40
alt-glitch
added
type/perf
|
Code Review: #77613 Verdict: Approve read_file hint: helpful UX improvement. LGTM - Reviewed diff. Changes are sound. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Salvage of #39399 by @rodboev — re-derived onto current main with authorship preserved (original was 5,721 commits behind; the npm invocation moved into _run_npm_install_deterministic).
npm install during 'hermes update' now passes --prefer-offline: npm consults its local cache before hitting the registry, cutting update time on repeat updates and making updates resilient to registry latency. Covers both call sites (root + workspace). 22 tests green (incl. the PR's test-expectation update, mirrored).
Closes #39399.