fix(hindsight): clarify pip dependency per mode in README - #7754
Closed
ten-ltw wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a documentation gap in
plugins/memory/hindsight/README.md— the "Client Version" section implied thathindsight-clientis the only required package, butlocal_embeddedmode actually requireshindsight-all.Changes
plugins/memory/hindsight/README.md:
Before:
```
Requires
hindsight-client >= 0.4.22. The plugin auto-upgrades on session start if an older version is detected.```
After: A dependency table is added:
cloudhindsight-client>= 0.4.22local_externalhindsight-client>= 0.4.22local_embeddedhindsight-all>= 0.5.0With a clear note that
hindsight-allis not auto-upgraded, and the install command to fix it.Related Issue
Partially addresses the documentation concern raised in #7718 (the code fix for #7718 is submitted separately as PR #7745).