fix(hindsight): add missing hindsight-all dep for local_embedded mode (closes #7718) - #7745
Closed
ten-ltw wants to merge 1 commit into
Closed
fix(hindsight): add missing hindsight-all dep for local_embedded mode (closes #7718)#7745ten-ltw wants to merge 1 commit into
ten-ltw wants to merge 1 commit into
Conversation
…closes NousResearch#7718) Root cause: local_embedded mode imports from hindsight.HindsightEmbedded (which requires the hindsight-all package), but plugin.yaml only declared hindsight-client as a dependency. Users selecting local_embedded experienced a silent ModuleNotFoundError on every on_session_end hook — their long-term memory was completely disabled with no visible signal. Fix: - plugin.yaml: declare both hindsight-client (cloud/external modes) and hindsight-all>=0.5.0 (local_embedded mode) as dependencies - initialize(): add guard import that raises a clear RuntimeError with install command if hindsight-all is absent - The legacy 'local' alias is also covered (silently remapped to local_embedded) Co-authored-by: Ten Li
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7718.
Root cause: local_embedded mode imports from hindsight.HindsightEmbedded (requires hindsight-all), but plugin.yaml only declared hindsight-client as a dependency. Users selecting local_embedded experienced a silent ModuleNotFoundError on every on_session_end hook.
Changes:
How to Test
# Verify 49/49 tests pass python -m pytest tests/plugins/memory/test_hindsight_provider.py -vFixes #7718