Skip to content

Add web_recent tool for cached web results - #768

Closed
luisv-1 wants to merge 1 commit into
NousResearch:mainfrom
luisv-1:feat/web-recent-results-tool
Closed

Add web_recent tool for cached web results#768
luisv-1 wants to merge 1 commit into
NousResearch:mainfrom
luisv-1:feat/web-recent-results-tool

Conversation

@luisv-1

@luisv-1 luisv-1 commented Mar 9, 2026

Copy link
Copy Markdown
Contributor

This PR introduces a web_recent tool that exposes a lightweight, in‑memory view of the most recent web_extract and web_crawl results, allowing the agent to quickly see which pages were just fetched without re‑calling Firecrawl.

Details

Adds an in‑process cache of trimmed web results
Updates web_extract_tool and web_crawl_tool to populate this cache after each call.
Registers a new web_recent tool and adds unit tests for get_last_web_results

@teknium1

teknium1 commented Mar 11, 2026

Copy link
Copy Markdown
Contributor

Thanks for the contribution @luisv-1! After review, we're going to pass on this one for a few reasons:

  1. Redundant with existing context — the agent already has web_extract/web_crawl results in its conversation history as tool results. It can reference them directly without needing a separate tool.

  2. Process-global cache — _last_web_results is module-level, so in the gateway (where all sessions share one process) one user's web results would leak into another user's web_recent call. This is both a privacy and correctness issue.

  3. Schema cost — every registered tool adds ~100-200 tokens to the system prompt on every API call. Adding a tool with marginal utility increases cost for all users.

Appreciate you thinking about ways to make the web tools more efficient though! 🙏

@teknium1 teknium1 closed this Mar 11, 2026
@benbarclay benbarclay mentioned this pull request Jul 23, 2026
Merged
pull Bot pushed a commit to jw5812018/hermes-agent that referenced this pull request Jul 29, 2026
@benbarclay
feat(sync): M2 org-skills client — _org/ pull, hermes skills propose,…
bdef497 
… 202 handling

Client leg of M2 org-shared skills (hsp-1-contract.md §11), pairing with
gateway-gateway #162 and NAS NousResearch#768 (both merged).

- resolve_org_identity(): org_id + org_role from the token claims. NO
  org_role claim (personal org — NAS only stamps it for multi-member orgs)
  => SyncInertError => every org surface is inert; personal M1 sync
  untouched (contract §11.1 REFINED). org_sync_available() for callers.
- pull_org_skills(): materialize the org canonical set (refs/org/<org_id>/
  HEAD) into ~/.hermes/skills/_org/<org_id>/ — fast-forward only, no client
  merge on the org path (design.md §2.6); read-only mirror by convention
  (§7.1: a local edit is a personal fork until proposed). maybe_pull_org_
  skills() best-effort hook (never raises; inert without the claim).
- propose_skill(): snapshot the LOCAL skill dir, splice it into the org
  HEAD's skill-tree map (per-skill delta, never wholesale replace), upload
  ?scope=org, CAS the org HEAD. ADMIN => direct merge; MEMBER => server
  converts to a proposal — cas_ref now surfaces 202 as
  {proposal_pending: True, proposal_id, ref} (success-shaped, NEVER
  presented as live). Non-interactive by design for the future automated
  submitter (Ben's trajectory note).
- put_objects(org_scope=True) adds ?scope=org (contract §11.5).
- is_sync_eligible(): skills under _org/ are excluded from PERSONAL sync —
  enterprise content never rides a personal push (§11.11).
- CLI: hermes skills propose <name> [-m msg] — prints 'pending admin
  review' for 202, 'merged' for admin, and a plain 'org sync unavailable'
  for personal orgs instead of a raw 403.

Tests: 56 in the sync client suite (+10 org: identity gate both ways, _org/
personal-sync exclusion, admin direct merge, member 202 w/ HEAD untouched +
proposal ref parked + never-merged, splice-not-replace root, pull mirror
materialization, no-head noop, org-feature gate, maybe_pull inert). Mock
server extended (org feature flag, member-CAS→202). 103 across skills
suites. Live CLI smoke: propose --help + personal-org inert path verified.
randlee pushed a commit to randlee/hermes-agent that referenced this pull request Aug 11, 2026
@benbarclay
feat(sync): M2 org-skills client — _org/ pull, hermes skills propose,…
ffff9c2 
… 202 handling

Client leg of M2 org-shared skills (hsp-1-contract.md §11), pairing with
gateway-gateway NousResearch#162 and NAS NousResearch#768 (both merged).

- resolve_org_identity(): org_id + org_role from the token claims. NO
  org_role claim (personal org — NAS only stamps it for multi-member orgs)
  => SyncInertError => every org surface is inert; personal M1 sync
  untouched (contract §11.1 REFINED). org_sync_available() for callers.
- pull_org_skills(): materialize the org canonical set (refs/org/<org_id>/
  HEAD) into ~/.hermes/skills/_org/<org_id>/ — fast-forward only, no client
  merge on the org path (design.md §2.6); read-only mirror by convention
  (§7.1: a local edit is a personal fork until proposed). maybe_pull_org_
  skills() best-effort hook (never raises; inert without the claim).
- propose_skill(): snapshot the LOCAL skill dir, splice it into the org
  HEAD's skill-tree map (per-skill delta, never wholesale replace), upload
  ?scope=org, CAS the org HEAD. ADMIN => direct merge; MEMBER => server
  converts to a proposal — cas_ref now surfaces 202 as
  {proposal_pending: True, proposal_id, ref} (success-shaped, NEVER
  presented as live). Non-interactive by design for the future automated
  submitter (Ben's trajectory note).
- put_objects(org_scope=True) adds ?scope=org (contract §11.5).
- is_sync_eligible(): skills under _org/ are excluded from PERSONAL sync —
  enterprise content never rides a personal push (§11.11).
- CLI: hermes skills propose <name> [-m msg] — prints 'pending admin
  review' for 202, 'merged' for admin, and a plain 'org sync unavailable'
  for personal orgs instead of a raw 403.

Tests: 56 in the sync client suite (+10 org: identity gate both ways, _org/
personal-sync exclusion, admin direct merge, member 202 w/ HEAD untouched +
proposal ref parked + never-merged, splice-not-replace root, pull mirror
materialization, no-head noop, org-feature gate, maybe_pull inert). Mock
server extended (org feature flag, member-CAS→202). 103 across skills
suites. Live CLI smoke: propose --help + personal-org inert path verified.
33hodl pushed a commit to 33hodl/hermes-agent that referenced this pull request Aug 12, 2026
@benbarclay
feat(sync): M2 org-skills client — _org/ pull, hermes skills propose,…
559823b 
… 202 handling

Client leg of M2 org-shared skills (hsp-1-contract.md §11), pairing with
gateway-gateway NousResearch#162 and NAS NousResearch#768 (both merged).

- resolve_org_identity(): org_id + org_role from the token claims. NO
  org_role claim (personal org — NAS only stamps it for multi-member orgs)
  => SyncInertError => every org surface is inert; personal M1 sync
  untouched (contract §11.1 REFINED). org_sync_available() for callers.
- pull_org_skills(): materialize the org canonical set (refs/org/<org_id>/
  HEAD) into ~/.hermes/skills/_org/<org_id>/ — fast-forward only, no client
  merge on the org path (design.md §2.6); read-only mirror by convention
  (§7.1: a local edit is a personal fork until proposed). maybe_pull_org_
  skills() best-effort hook (never raises; inert without the claim).
- propose_skill(): snapshot the LOCAL skill dir, splice it into the org
  HEAD's skill-tree map (per-skill delta, never wholesale replace), upload
  ?scope=org, CAS the org HEAD. ADMIN => direct merge; MEMBER => server
  converts to a proposal — cas_ref now surfaces 202 as
  {proposal_pending: True, proposal_id, ref} (success-shaped, NEVER
  presented as live). Non-interactive by design for the future automated
  submitter (Ben's trajectory note).
- put_objects(org_scope=True) adds ?scope=org (contract §11.5).
- is_sync_eligible(): skills under _org/ are excluded from PERSONAL sync —
  enterprise content never rides a personal push (§11.11).
- CLI: hermes skills propose <name> [-m msg] — prints 'pending admin
  review' for 202, 'merged' for admin, and a plain 'org sync unavailable'
  for personal orgs instead of a raw 403.

Tests: 56 in the sync client suite (+10 org: identity gate both ways, _org/
personal-sync exclusion, admin direct merge, member 202 w/ HEAD untouched +
proposal ref parked + never-merged, splice-not-replace root, pull mirror
materialization, no-head noop, org-feature gate, maybe_pull inert). Mock
server extended (org feature flag, member-CAS→202). 103 across skills
suites. Live CLI smoke: propose --help + personal-org inert path verified.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@luisv-1 @teknium1