Skip to content

test(gateway): exercise bundled platform contracts - #74953

Open
kaitwalla wants to merge 1 commit into
NousResearch:mainfrom
kaitwalla:fix/platform-contract-discovery
Open

kaitwalla wants to merge 1 commit into
NousResearch:mainfrom
kaitwalla:fix/platform-contract-discovery

Conversation

@kaitwalla

Copy link
Copy Markdown

Summary

  • correct the repository root used by bundled-platform discovery
  • fail explicitly if the dynamic contract suite discovers no platforms
  • let the minimal context accept secondary CLI and lifecycle-hook registrations

Previously the path resolved to tests/plugins/platforms, so both parametrized contract tests skipped silently.

Test plan

  • pytest tests/gateway/test_plugin_platform_interface.py -q — 43 passed
  • ruff check tests/gateway/test_plugin_platform_interface.py
  • git diff --check

This is intentionally separate from the standalone Fluxer plugin extraction requested on #73528.

@alt-glitch alt-glitch added type/test Test coverage or test infrastructure comp/gateway Gateway runner, session dispatch, delivery comp/plugins Plugin system and bundled plugins P3 Low — cosmetic, nice to have labels Jul 30, 2026
@teknium1

Copy link
Copy Markdown
Collaborator

Thanks for isolating the contract-test correction. The premise is confirmed on current main: tests/gateway/test_plugin_platform_interface.py:17-18 resolves discovery under tests/plugins/platforms, while bundled adapters live under plugins/platforms/. The added guard prevents this dynamic suite from silently becoming all-skipped, and the mock additions cover existing Photon CLI registration (plugins/platforms/photon/adapter.py:2881) and Raft lifecycle-hook registration (plugins/platforms/raft/adapter.py:846-852).

Automated hermes-sweeper review.

@teknium1 teknium1 added the sweeper:blast-contained Sweeper blast radius: contained — one narrow path / opt-in / few users label Jul 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/gateway Gateway runner, session dispatch, delivery comp/plugins Plugin system and bundled plugins P3 Low — cosmetic, nice to have sweeper:blast-contained Sweeper blast radius: contained — one narrow path / opt-in / few users type/test Test coverage or test infrastructure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants