Conversation
teknium1
reviewed
Jul 30, 2026
teknium1
left a comment
Collaborator
There was a problem hiding this comment.
Thank you for the substantial adapter implementation and the focused gateway coverage.
Problems
- The new bundled integration at
plugins/platforms/fluxer/plugin.yaml:1conflicts with the standing policy atAGENTS.md:797-810: new third-party-product plugins must ship as standalone plugin repositories rather than new directories underplugins/. - This PR also contains a separately valid current-main repair.
tests/gateway/test_plugin_platform_interface.py:17-18buildstests/plugins/platforms, not the repository'splugins/platforms; its dynamic platform parameter set therefore does not cover bundled adapters.
Suggested changes
- Publish Fluxer as a standalone platform plugin using the existing
ctx.register_platform()surface, which current docs identify for user-installed third-party platform adapters (website/docs/user-guide/features/plugins.md:180,230). - Keep the
PROJECT_ROOTcorrection as a focused contract-test change so the existing bundled-platform checks actually execute.
This is an automated hermes-sweeper review.
| @@ -0,0 +1,56 @@ | |||
| name: fluxer-platform | |||
Collaborator
There was a problem hiding this comment.
This creates a new in-tree third-party product integration. AGENTS.md:797-810 requires such plugins to ship as standalone repositories installable under ~/.hermes/plugins/; please move the Fluxer adapter to that extension path rather than adding it under plugins/.
Author
|
Superseded by the standalone plugin repository requested in review:
The unrelated bundled-platform contract-test correction is now isolated in #74953. Closing this monorepo integration PR in favor of those two focused deliverables. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security and isolation
True; unknown text still reaches central pairing--replacetakeover semanticsVerification
67 passed— focused Fluxer unit/setup/in-process REST+WebSocket integration suite793 passed— selected platform/config/session contracts,0 skippedtypassed11,571 passed,21 failed,4 skipped; no Fluxer tests failed. The 21 unrelated failures were rerun by file: 20 passed, and the remaining busy-ack test passed with an isolatedHERMES_HOME(the live profile hadbusy_ack_detailenabled).Notes
The adapter talks to Fluxer natively; it does not redirect or impersonate the Discord adapter. Self-hosted REST bases are full versioned URLs such as
https://chat.example.com/api/v1.