fix: add TTY guard in _offer_launch_chat to prevent crash in non-inte… - #7469
Closed
tomly wants to merge 1 commit into
Closed
fix: add TTY guard in _offer_launch_chat to prevent crash in non-inte…#7469tomly wants to merge 1 commit into
tomly wants to merge 1 commit into
Conversation
…ractive environments When hermes setup is run in a non-interactive environment (e.g., sandbox, pipe, or automated script), _offer_launch_chat() would call cmd_chat() without checking TTY availability, causing prompt_toolkit to crash with: OSError: [Errno 22] Invalid argument (kqueue selector cannot register stdin fd=0 in non-TTY) This patch adds a guard using is_interactive_stdin() to gracefully exit with helpful guidance instead of crashing. Fixes issue discovered in OpenClaw sandbox environment where: - tty returns 'not a tty' - Terminal type is 'openclaw-gateway' (sandbox)
Collaborator
Contributor
|
Closing as stale — the code path this addresses no longer exists on Triage notes (high confidence): If this PR's intent is still relevant against the current code, please rebase or open a fresh PR. (Bulk-closed during a CLI PR triage sweep.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ractive environments
When hermes setup is run in a non-interactive environment (e.g., sandbox, pipe, or automated script), _offer_launch_chat() would call cmd_chat() without checking TTY availability, causing prompt_toolkit to crash with:
OSError: [Errno 22] Invalid argument
(kqueue selector cannot register stdin fd=0 in non-TTY)
This patch adds a guard using is_interactive_stdin() to gracefully exit with helpful guidance instead of crashing.
Fixes issue discovered in OpenClaw sandbox environment where:
What does this PR do?
Related Issue
Fixes #
Type of Change
Changes Made
How to Test
Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AFor New Skills
hermes --toolsets skills -q "Use the X skill to do Y"Screenshots / Logs